Bug 101695

Summary: Uninitialized fields in class JSLock
Product: WebKit Reporter: Cosmin Truta <ctruta>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dglazkov, mark.lam, mhahnenberg, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Cosmin Truta
Reported 2012-11-08 20:17:19 PST
Valgrind reported that JSLock::m_ownerThread is not initialized. The report indicates a legitimate issue. A fix will follow.
Attachments
Patch (1001 bytes, patch)
2012-11-08 20:22 PST, Cosmin Truta 		no flags
DetailsFormatted DiffDiff
Patch (1.10 KB, patch)
2012-11-10 21:12 PST, Cosmin Truta 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cosmin Truta
Comment 1 2012-11-08 20:22:40 PST
Created attachment 173186 [details] Patch
Mark Hahnenberg
Comment 2 2012-11-09 14:39:35 PST
Comment on attachment 173186 [details] Patch I think we should also initialize m_lockDropDepth, no?
Cosmin Truta
Comment 3 2012-11-10 21:12:33 PST
Created attachment 173484 [details] Patch (In reply to comment #2) > I think we should also initialize m_lockDropDepth, no? You're right. Done.
WebKit Review Bot
Comment 4 2012-11-10 22:04:43 PST
Comment on attachment 173484 [details] Patch Attachment 173484 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14786720 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Cosmin Truta
Comment 5 2012-11-11 14:54:20 PST
Comment on attachment 173484 [details] Patch Setting back "cq?". Something seems to be wrong with the Chrome-Linux build.
Mark Hahnenberg
Comment 6 2012-11-13 08:31:20 PST
(In reply to comment #5) > (From update of attachment 173484 [details]) > Setting back "cq?". Something seems to be wrong with the Chrome-Linux build. I think that's just a flaky test. Chrome doesn't use JSC and therefore doesn't depend on JSLock in any way.
Mark Hahnenberg
Comment 7 2012-11-13 08:33:19 PST
Comment on attachment 173484 [details] Patch r=me
WebKit Review Bot
Comment 8 2012-11-13 09:17:41 PST
Comment on attachment 173484 [details] Patch Clearing flags on attachment: 173484 Committed r134430: <http://trac.webkit.org/changeset/134430>
WebKit Review Bot
Comment 9 2012-11-13 09:17:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.