Bug 101664

Summary: Null check URL key entries into WebHistory hash table
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: HistoryAssignee: Roger Fong <roger_fong>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch
none
Patch beidson: review+

Roger Fong
Reported 2012-11-08 16:24:53 PST
This a workaround. Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown.
Attachments
Patch (1.52 KB, patch)
2012-11-08 16:30 PST, Roger Fong 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2012-11-08 16:53 PST, Roger Fong 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-11-08 16:30:58 PST
Created attachment 173145 [details] Patch
Brady Eidson
Comment 2 2012-11-08 16:35:30 PST
Comment on attachment 173145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173145&action=review > Source/WebKit/mac/ChangeLog:4 > + Null check URL key entries into WebHistory hash table. > + https://bugs.webkit.org/show_bug.cgi?id=101664 Can include the rdar: number here, too. > Source/WebKit/mac/ChangeLog:10 > + This a workaround. > + Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown > + so that navigation can continue as expected. Workaround for what? *I* know, but future readers of this ChangeLog who aren't me won't know.
Roger Fong
Comment 3 2012-11-08 16:53:03 PST
Created attachment 173149 [details] Patch
Roger Fong
Comment 4 2012-11-08 16:53:39 PST
(In reply to comment #3) > Created an attachment (id=173149) [details] > Patch fixed changelog
Roger Fong
Comment 5 2012-11-08 17:21:30 PST
Committed: http://trac.webkit.org/changeset/133977
Note You need to log in before you can comment on or make changes to this bug.