Bug 101632

Summary: [Cmake] Consolidate common input files
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, paroga, rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
1st try
rwlbuis: review+
for cq none

Laszlo Gombos
Reported 2012-11-08 12:13:22 PST
Most files under WebCore/platform/image-decoders are common between ports - these can be consolidated under the common cmake-file. Also consolidated some of the EFL specific cmake files after http://trac.webkit.org/changeset/133891 .
Attachments
1st try (13.11 KB, patch)
2012-11-08 12:18 PST, Laszlo Gombos 		rwlbuis: review+
DetailsFormatted DiffDiff
for cq (13.18 KB, patch)
2012-11-18 17:46 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-11-08 12:18:57 PST
Created attachment 173089 [details] 1st try
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-11-09 04:45:59 PST
Comment on attachment 173089 [details] 1st try View in context: https://bugs.webkit.org/attachment.cgi?id=173089&action=review No objections. > Source/WebCore/ChangeLog:3 > + [Cmake] Consolidate common input files Cmake -> CMake
Rob Buis
Comment 3 2012-11-09 07:28:06 PST
Comment on attachment 173089 [details] 1st try Looks good.
Laszlo Gombos
Comment 4 2012-11-18 17:46:51 PST
Created attachment 174867 [details] for cq
WebKit Review Bot
Comment 5 2012-11-18 19:03:30 PST
Comment on attachment 174867 [details] for cq Clearing flags on attachment: 174867 Committed r135100: <http://trac.webkit.org/changeset/135100>
WebKit Review Bot
Comment 6 2012-11-18 19:03:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.