Bug 101627

Summary:

REGRESSION (r125239): classList contains() doesn't work after element was moved from strict mode document to quirks mode document

Product:

WebKit

Reporter:

Brad Vogel <bradavogel>

Component:

DOM

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, arv, bradavogel, leviw, ojan, webkit.review.bot

Priority:

Keywords:

Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
test case	none
Patch	none

Brad Vogel

Reported 2012-11-08 11:22:08 PST

Created attachment 173080 [details] test case Browsers tested: Chrome 22 - PASS Chrome 23.0.1271.64 - FAIL Safari 6 (AppleWebKit/536.26.17) - PASS Webkit Nightly 6.0.2 (AppleWebKit/537.19+) - FAIL Repro: Run the attached file. Expected: The alert dialog shows: contains "newclass": true Actual: The alert dialog shows: contains "newclass": false Notes: Adding a doctype to the iframe is a workaround to the issue: doc.write('<!doctype html><html><body></body></html>');

Attachments
test case (921 bytes, text/html) 2012-11-08 11:22 PST, Brad Vogel	no flags	Details
Patch (7.74 KB, patch) 2012-11-08 14:25 PST, Erik Arvidsson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Erik Arvidsson

Comment 1 2012-11-08 13:11:17 PST

This happens when an element is moved from a standards mode document to a quirks mode document since the internal list of class names now needs to be handled by the ClassList. We need to verify that ClassList::classNames returns an up to date SpaceSplitString. Is this really a regression? I'm surprised this ever worked.

Brad Vogel

Comment 2 2012-11-08 13:49:17 PST

Yes, I verified it worked on Chrome 22 and Safari 6.

Alexey Proskuryakov

Comment 3 2012-11-08 14:02:49 PST

Definitely a regression, I bisected to <http://trac.webkit.org/changeset/125239>.

Erik Arvidsson

Comment 4 2012-11-08 14:25:00 PST

Created attachment 173115 [details] Patch

WebKit Review Bot

Comment 5 2012-11-09 12:55:22 PST

Comment on attachment 173115 [details] Patch Clearing flags on attachment: 173115 Committed r134102: <http://trac.webkit.org/changeset/134102>

WebKit Review Bot

Comment 6 2012-11-09 12:55:26 PST

All reviewed patches have been landed. Closing bug.

Brad Vogel

Comment 7 2012-11-09 13:29:26 PST

Thanks!

Levi Weintraub

Comment 8 2013-01-07 15:56:11 PST

You may want to merge this into m25 given it's super low risk and high return.

Levi Weintraub

Comment 9 2013-01-07 15:56:29 PST

(In reply to comment #8) > You may want to merge this into m25 given it's super low risk and high return. Whoops, wrong bug.

Note You need to log in before you can comment on or make changes to this bug.