Bug 101601

Summary:

Web Inspector: Add an option to switch display of "Other" memory on/off in NMI

Product:

WebKit

Reporter:

Alexei Filippov <alph>

Component:

Web Inspector (Deprecated)

Assignee:

Alexei Filippov <alph>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Alexei Filippov

Reported 2012-11-08 07:04:43 PST

EOM

Attachments
Patch (4.08 KB, patch) 2012-11-08 07:09 PST, Alexei Filippov	no flags	Details Formatted Diff Diff
Patch (3.86 KB, patch) 2012-11-09 05:45 PST, Alexei Filippov	no flags	Details Formatted Diff Diff
Patch (4.80 KB, patch) 2012-11-11 09:36 PST, Alexei Filippov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexei Filippov

Comment 1 2012-11-08 07:09:00 PST

Created attachment 173037 [details] Patch

Yury Semikhatsky

Comment 2 2012-11-09 05:10:54 PST

Comment on attachment 173037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173037&action=review > Source/WebCore/inspector/front-end/SettingsScreen.js:289 > + p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show object hidden properties"), WebInspector.settings.showHeapSnapshotObjectsHiddenProperties)); Please revert this.

Alexei Filippov

Comment 3 2012-11-09 05:41:23 PST

Comment on attachment 173037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173037&action=review >> Source/WebCore/inspector/front-end/SettingsScreen.js:289 >> + p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show object hidden properties"), WebInspector.settings.showHeapSnapshotObjectsHiddenProperties)); > > Please revert this. I found it to be wrong English. AFAIK possessive case can only be applied to humans and animals, I doubt object is an animal. Anyway I can revert this change as it's not related to the fix.

Alexei Filippov

Comment 4 2012-11-09 05:45:58 PST

Created attachment 173279 [details] Patch

Yury Semikhatsky

Comment 5 2012-11-09 06:00:14 PST

Comment on attachment 173279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173279&action=review > Source/WebCore/inspector/front-end/SettingsScreen.js:291 > + p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show uninstrumented native memory"), WebInspector.settings.showNativeSnapshotUninstrumentedSize)); Please add new string to localizedStrings.js

Alexei Filippov

Comment 6 2012-11-11 09:36:00 PST

Created attachment 173508 [details] Patch

Alexei Filippov

Comment 7 2012-11-11 09:57:57 PST

Comment on attachment 173279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173279&action=review >> Source/WebCore/inspector/front-end/SettingsScreen.js:291 >> + p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show uninstrumented native memory"), WebInspector.settings.showNativeSnapshotUninstrumentedSize)); > > Please add new string to localizedStrings.js Done

WebKit Review Bot

Comment 8 2012-11-12 20:59:31 PST

Comment on attachment 173508 [details] Patch Clearing flags on attachment: 173508 Committed r134354: <http://trac.webkit.org/changeset/134354>

WebKit Review Bot

Comment 9 2012-11-12 20:59:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.