Bug 101588

Summary: [Qt] Fix build with MSVC 2012 and Angle
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, dino, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Hausmann
Reported 2012-11-08 04:39:19 PST
[Qt] Fix build with MSVC 2012
Attachments
Patch (1.94 KB, patch)
2012-11-08 04:44 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (6.34 KB, patch)
2012-11-08 06:15 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-11-08 04:44:09 PST
Created attachment 173014 [details] Patch
Simon Hausmann
Comment 2 2012-11-08 06:15:36 PST
Created attachment 173030 [details] Patch
Simon Hausmann
Comment 3 2012-11-08 06:35:53 PST
Comment on attachment 173030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173030&action=review > Source/ThirdParty/ANGLE/Target.pri:27 > > CONFIG += staticlib > > +# Pull in WTF include paths, because for Windows we need > +# JavaScriptCore/os-win32/stdint.h, which in turn needs wtf/Platform.h > +defineTest(addIncludePaths) { > + # Just needed for include paths > + include(../../WTF/WTF.pri) > + > + export(INCLUDEPATH) > +} > + > +addIncludePaths() > + > INCLUDEPATH += \ > $$SOURCE_DIR/src \ > $$SOURCE_DIR/src/compiler/preprocessor/new \ Clearing review. After quick discussion and face-to-face review with Tor Arne I'm removing this part altogether (it shouldn't be needed) and if it works will land it.
Simon Hausmann
Comment 4 2012-11-29 05:19:09 PST
Committed r133896: <http://trac.webkit.org/changeset/133896>
Note You need to log in before you can comment on or make changes to this bug.