Bug 101586

Summary: MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, hta, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Tommy Widenflycht
Reported 2012-11-08 04:37:32 PST
MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
Attachments
Patch (1.72 KB, patch)
2012-11-08 04:44 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-11-08 04:44:01 PST
Created attachment 173013 [details] Patch
Tommy Widenflycht
Comment 2 2012-11-08 04:50:54 PST
Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new API some WebCore objects might be cleaned away which is not allowed at this stage.
Adam Barth
Comment 3 2012-11-09 11:19:17 PST
Comment on attachment 173013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173013&action=review > Source/WebCore/ChangeLog:12 > + This behaviour is not possible to test unfortunately in webkit. Do we have tests in Chromium to cover this issue?
WebKit Review Bot
Comment 4 2012-11-09 11:39:31 PST
Comment on attachment 173013 [details] Patch Clearing flags on attachment: 173013 Committed r134093: <http://trac.webkit.org/changeset/134093>
WebKit Review Bot
Comment 5 2012-11-09 11:39:34 PST
All reviewed patches have been landed. Closing bug.
Tommy Widenflycht
Comment 6 2012-11-12 00:32:37 PST
Comment on attachment 173013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173013&action=review >> Source/WebCore/ChangeLog:12 >> + This behaviour is not possible to test unfortunately in webkit. > > Do we have tests in Chromium to cover this issue? No, but we (the WebRTC team) have our own bots that run pyautotests and some fuzzer tests. Our SETs is working on having these tests integrated into the main chromium tree.
Note You need to log in before you can comment on or make changes to this bug.