Bug 101586

Summary: MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, hta, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Description Tommy Widenflycht 2012-11-08 04:37:32 PST 
MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
Comment 1 Tommy Widenflycht 2012-11-08 04:44:01 PST 
Created attachment 173013 [details]
Patch
Comment 2 Tommy Widenflycht 2012-11-08 04:50:54 PST 
Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new API some WebCore objects might be cleaned away which is not allowed at this stage.
Comment 3 Adam Barth 2012-11-09 11:19:17 PST 
Comment on attachment 173013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173013&action=review

> Source/WebCore/ChangeLog:12
> +        This behaviour is not possible to test unfortunately in webkit.

Do we have tests in Chromium to cover this issue?
Comment 4 WebKit Review Bot 2012-11-09 11:39:31 PST 
Comment on attachment 173013 [details]
Patch

Clearing flags on attachment: 173013

Committed r134093: <http://trac.webkit.org/changeset/134093>
Comment 5 WebKit Review Bot 2012-11-09 11:39:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Tommy Widenflycht 2012-11-12 00:32:37 PST 
Comment on attachment 173013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173013&action=review

>> Source/WebCore/ChangeLog:12
>> +        This behaviour is not possible to test unfortunately in webkit.
> 
> Do we have tests in Chromium to cover this issue?

No, but we (the WebRTC team) have our own bots that run pyautotests and some fuzzer tests. Our SETs is working on having these tests integrated into the main chromium tree.