Bug 101581

Summary: [GTK] Do not use 'ls' to list IDL files in EXTRA_DIST
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xan Lopez
Reported 2012-11-08 03:33:43 PST
There's really no need to do so, and it will fail in a noisy way when a file is not present: ls: cannot access ../../Source/WebCore/editing/*.idl: No such file or directory Instead just use normal wildcards with $(wildcard). Patch attached, verified that make dist still works with it.
Attachments
Patch (5.14 KB, patch)
2012-11-08 03:36 PST, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2012-11-08 03:36:39 PST
Created attachment 172993 [details] Patch
Martin Robinson
Comment 2 2012-11-09 08:45:22 PST
Comment on attachment 172993 [details] Patch Okay. It's also a good idea to remove the editing directory from the list. The warning usually indicates the files were moved and the directory now shouldn't be listed.
Xan Lopez
Comment 3 2012-11-09 09:10:02 PST
Comment on attachment 172993 [details] Patch Pushed with the requested changes.
Xan Lopez
Comment 4 2012-11-09 09:10:09 PST
Closing.
Note You need to log in before you can comment on or make changes to this bug.