Bug 101572 – [Qt] Scriptable Color Chooser

• Component: WebKit Qt
• Status: RESOLVED INVALID

[Allan Sandfeld Jensen]

We have very basic support for the HTML5 Color input, it can pick a color using a modal dialog but not much else. It should be simple to provide better access to few extra functions ColorChooser supports: Updating current selected color and closing the dialog by script.

[Allan Sandfeld Jensen]

Created attachment 172974 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 172974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172974&action=review

> Source/WebKit/qt/ChangeLog:8
> +        Add a thin wrapper around QDialog and use that as our color chooser instead of the fire-and-forget interface.

Please add in the changelog the motivation of the patch (allowing the user to do X and Y)

> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:600
> +    OwnPtr<ColorChooser> colorChooser = adoptPtr(new ColorChooserQt(m_webPage->view(), client, color));

I think that m_webPage->view() won't get you what you want when using QGraphicsWebView. It would probably be better to keep the previous parent logic from colorSelectionRequested.

> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:603
> +    return adoptPtr(nullptr);

PassOwnPtr<ColorChooser>() would be more appropriate.

> Source/WebKit/qt/WebCoreSupport/ColorChooserQt.cpp:33
> +class ColorChooserProxyQt : public QObject {

Check if you can avoid the delegate object.
If you need it please use a different term than "Proxy" which usually refers to multiprocess stuff. "Private" would be a more common suffix.

[Anders Carlsson]

Comment on attachment 172974 [details]
Patch

Qt has been removed, clearing review flags.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.