Bug 101526 – [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Yael]

We should turn on WTF_USE_TILED_BACKING_STORE by default.
Attaching the results of a test run with TILED_BACKING_STORE on. More tests are newly passing than failing.

[Yael]

Created attachment 172898 [details]
Layout tests results

[Yael]

Created attachment 172899 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 172899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172899&action=review

> ChangeLog:8
> +        Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

It might not be 100% working, but does it break anything? If not, why not jsut enable it?

[WebKit Review Bot]

Comment on attachment 172899 [details]
Patch

Clearing flags on attachment: 172899

Committed r133859: <http://trac.webkit.org/changeset/133859>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mikhail Pozdnyakov]

Shouldn't we also unskip/rebaseline the related tests at the same time?

[Chris Dumez]

(In reply to comment #6)
> Shouldn't we also unskip/rebaseline the related tests at the same time?

Agreed, that would have been nice.
It would also make the impact of this change more obvious.

[Dominik Röttsches (drott)]

Reverted r133859 for reason:

Breaks EFL bots test execution.

Committed r133875: <http://trac.webkit.org/changeset/133875>

[Dominik Röttsches (drott)]

When landing this again, please incorporate
http://trac.webkit.org/changeset/133865

[Mikhail Pozdnyakov]

Had following error log on bot:

02:58:47.244 22101   ERR<22224>:ecore ecore.c:558 _ecore_magic_fail() 
02:58:47.244 22101   *** ECORE ERROR: Ecore Magic Check Failed!!!
02:58:47.244 22101   *** IN FUNCTION: ecore_evas_get()
02:58:47.244 22101   ERR<22224>:ecore ecore.c:560 _ecore_magic_fail()   Input handle pointer is NULL!
02:58:47.244 22101   ERR<22224>:ecore ecore.c:571 _ecore_magic_fail() *** NAUGHTY PROGRAMMER!!!
02:58:47.244 22101   *** SPANK SPANK SPANK!!!
02:58:47.244 22101   *** Now go fix your code. Tut tut tut!
02:58:47.244 22101   ERR<22224>: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:500 createEwkView() safety check failed: canvas == NULL
02:58:47.244 22101   CRI<22224>: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:658 ewk_view_theme_set() null is not a ewk_view
02:58:47.244 22101   CRI<22224>: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:658 ewk_view_theme_set() no smart data for object (nil) ((null))
02:58:47.244 22101   ASSERTION FAILED: view
02:58:47.244 22101   /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp(183) : static EwkViewImpl* EwkViewImpl::fromEvasObject(const Evas_Object*)
02:58:47.244 22101   1   0x7f11972f0c07 EwkViewImpl::fromEvasObject(_Evas_Object const*)
02:58:47.244 22101   2   0x7f11972ef7d9 WKViewGetPage
02:58:47.244 22101   3   0x430593 WTR::PlatformWebView::page()
02:58:47.244 22101   4   0x41bebd WTR::TestController::createWebViewWithOptions(OpaqueWKDictionary const*)
02:58:47.244 22101   5   0x41bc16 WTR::TestController::initialize(int, char const**)
02:58:47.244 22101   6   0x41ac7a WTR::TestController::TestController(int, char const**)
02:58:47.244 22101   7   0x430a22 main
02:58:47.244 22101   8   0x7f119501a76d __libc_start_main

Might be due to missing GL support (Everything is working locally)

[Thiago Marcos P. Santos]

(In reply to comment #10)
> Had following error log on bot:
> 
> 02:58:47.244 22101   ERR<22224>:ecore ecore.c:558 _ecore_magic_fail() 
> 02:58:47.244 22101   *** ECORE ERROR: Ecore Magic Check Failed!!!
> 02:58:47.244 22101   *** IN FUNCTION: ecore_evas_get()
> 02:58:47.244 22101   ERR<22224>:ecore ecore.c:560 _ecore_magic_fail()   Input handle pointer is NULL!
> 02:58:47.244 22101   ERR<22224>:ecore ecore.c:571 _ecore_magic_fail() *** NAUGHTY PROGRAMMER!!!
> 02:58:47.244 22101   *** SPANK SPANK SPANK!!!
> 02:58:47.244 22101   *** Now go fix your code. Tut tut tut!
> 02:58:47.244 22101   ERR<22224>: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:500 createEwkView() safety check failed: canvas == NULL
> 02:58:47.244 22101   CRI<22224>: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:658 ewk_view_theme_set() null is not a ewk_view
> 02:58:47.244 22101   CRI<22224>: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:658 ewk_view_theme_set() no smart data for object (nil) ((null))
> 02:58:47.244 22101   ASSERTION FAILED: view
> 02:58:47.244 22101   /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp(183) : static EwkViewImpl* EwkViewImpl::fromEvasObject(const Evas_Object*)
> 02:58:47.244 22101   1   0x7f11972f0c07 EwkViewImpl::fromEvasObject(_Evas_Object const*)
> 02:58:47.244 22101   2   0x7f11972ef7d9 WKViewGetPage
> 02:58:47.244 22101   3   0x430593 WTR::PlatformWebView::page()
> 02:58:47.244 22101   4   0x41bebd WTR::TestController::createWebViewWithOptions(OpaqueWKDictionary const*)
> 02:58:47.244 22101   5   0x41bc16 WTR::TestController::initialize(int, char const**)
> 02:58:47.244 22101   6   0x41ac7a WTR::TestController::TestController(int, char const**)
> 02:58:47.244 22101   7   0x430a22 main
> 02:58:47.244 22101   8   0x7f119501a76d __libc_start_main
> 
> Might be due to missing GL support (Everything is working locally)

Looks like GL works fine on the bots using Xvfb. It falls back to llvm pipe automagically (same as on our desktop). It has to be something else.

[Sudarsana Nagineni (babu)]

(In reply to comment #10)
> Might be due to missing GL support (Everything is working locally)

It seems evas was compiled before the GL dependencies were installed on the bot, so the required module to create the Ecore_Evas based on opengl_x11 engine is missing in the libs. 

I guess triggering a clean build (including the build dependencies) should solve the issue. I'm going to check this now offline on the bot.

[Sudarsana Nagineni (babu)]

Triggering clean build solves the issue on bots. Could someone please reland the patch?

[Thiago Marcos P. Santos]

(In reply to comment #13)
> Triggering clean build solves the issue on bots. Could someone please reland the patch?

Nice finding Babu!

[WebKit Review Bot]

Comment on attachment 172899 [details]
Patch

Clearing flags on attachment: 172899

Committed r133898: <http://trac.webkit.org/changeset/133898>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kangil Han]

Can anyone kindly let EFL WebKittens know how we can avoid 100% crash in layout test? Some of them even can't imagine what has happened on his environment. :)

[Yael]

(In reply to comment #17)
> Can anyone kindly let EFL WebKittens know how we can avoid 100% crash in layout test? Some of them even can't imagine what has happened on his environment. :)

This is because of missing dependencies in the deveoplers' systems.
I did not narrow down which packages exactly are missing, but according to http://qt-project.org/wiki/Building_Qt_5_from_Git , you should do the following:
sudo apt-get install "^libxcb.*" libx11-xcb-dev libglu1-mesa-dev libxrender-dev

[Dominik Röttsches (drott)]

(In reply to comment #18)
> This is because of missing dependencies in the deveoplers' systems.
> [...]

If there are additional packages required, could you make sure (using a new bug) that CMAKE catches this correctly?

[Thiago Marcos P. Santos]

(In reply to comment #18)
> (In reply to comment #17)
> > Can anyone kindly let EFL WebKittens know how we can avoid 100% crash in layout test? Some of them even can't imagine what has happened on his environment. :)
> 
> This is because of missing dependencies in the deveoplers' systems.
> I did not narrow down which packages exactly are missing, but according to http://qt-project.org/wiki/Building_Qt_5_from_Git , you should do the following:
> sudo apt-get install "^libxcb.*" libx11-xcb-dev libglu1-mesa-dev libxrender-dev

I suggest installing Ubuntu 12.04 in a VM and check the exact packages we need. We need this list on our wiki and it has to be consistent. "^libxcb.*" wont help much.


The hack bellow might give you some hints:
$ for i in $(ldd WebKitBuild/Debug/bin/WebProcess |cut -d' ' -f3 |grep -v $USER); do dpkg -S $i; done |cut -d: -f1 |sort |uniq

My results -> http://pastie.org/pastes/5365948/text

[Yael]

(In reply to comment #19)
> (In reply to comment #18)
> > This is because of missing dependencies in the deveoplers' systems.
> > [...]
> 
> If there are additional packages required, could you make sure (using a new bug) that CMAKE catches this correctly?

I started working on this, but on a second thought, after https://bugs.webkit.org/show_bug.cgi?id=101659, and  you should be able to use webkit-efl without those dependencies.

[WebKit Review Bot]

Re-opened since this is blocked by bug 102875

[Gyuyoung Kim]

Created attachment 175392 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 175392 [details]
Patch

Clearing flags on attachment: 175392

Committed r135375: <http://trac.webkit.org/changeset/135375>

[Gyuyoung Kim]

All reviewed patches have been landed.  Closing bug.