Bug 101517 – [EFL][WK2] Rename variables, structures and functions of the MiniBrowser.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Byungwoo Lee]

Need to arrange the naming of the MiniBrowser source.

[Byungwoo Lee]

Created attachment 172885 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 172885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172885&action=review

Should we change existing naming ? Christophe, do you agree this change ?

> Tools/MiniBrowser/efl/main.c:102
> +static Browser_Window *find_window_with_elm_window(Evas_Object *elm_window)

browser_window_find is more close EFL style.

[Byungwoo Lee]

(In reply to comment #2)
> (From update of attachment 172885 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172885&action=review
> 
> Should we change existing naming ? Christophe, do you agree this change ?
> 
> > Tools/MiniBrowser/efl/main.c:102
> > +static Browser_Window *find_window_with_elm_window(Evas_Object *elm_window)
> 
> browser_window_find is more close EFL style.

Currently, browser_window_find() returns Browser_Window. and browser_view_find() also returns Browser_Window.

I thought that the name is confused, so I tried to change this.

I'll change the name to 'window_find_with_{ewk_view|elm_window}() and upload again.

[Byungwoo Lee]

Created attachment 172908 [details]
Patch

[Byungwoo Lee]

Created attachment 172948 [details]
Patch

[Byungwoo Lee]

(In reply to comment #5)
> Created an attachment (id=172948) [details]
> Patch

Fixed typo in ChangeLog.

[Byungwoo Lee]

Created attachment 173581 [details]
Patch

[Byungwoo Lee]

(In reply to comment #7)
> Created an attachment (id=173581) [details]
> Patch

Rebased with the latest source.

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 172885 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172885&action=review
> 
> Should we change existing naming ? Christophe, do you agree this change ?

Christophe, do you agree this patch ?

[Chris Dumez]

(In reply to comment #9)
> (In reply to comment #2)
> > (From update of attachment 172885 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=172885&action=review
> > 
> > Should we change existing naming ? Christophe, do you agree this change ?
> 
> Christophe, do you agree this patch ?

Sure, LGTM. I also think a clean up was needed.
Personally, I would also like the file to be split because main.c is becoming too big.

[Mikhail Pozdnyakov]

Comment on attachment 173581 [details]
Patch

looks nice

[WebKit Review Bot]

Comment on attachment 173581 [details]
Patch

Rejecting attachment 173581 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
25 succeeded at 819 (offset 5 lines).
Hunk #26 succeeded at 894 (offset 5 lines).
Hunk #27 succeeded at 905 (offset 5 lines).
Hunk #28 succeeded at 940 with fuzz 2 (offset 5 lines).
Hunk #29 succeeded at 974 (offset 5 lines).
Hunk #30 FAILED at 1026.
2 out of 30 hunks FAILED -- saving rejects to file Tools/MiniBrowser/efl/main.c.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gyuyoung K..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14815985

[Byungwoo Lee]

Created attachment 174115 [details]
Patch

[Byungwoo Lee]

Comment on attachment 174115 [details]
Patch

Rebased.

[WebKit Review Bot]

Comment on attachment 174115 [details]
Patch

Clearing flags on attachment: 174115

Committed r134583: <http://trac.webkit.org/changeset/134583>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.