Bug 101507

Summary: OpaqueJSClassContextData() should use StringImpl::isolatedCopy() to make string copies
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2012-11-07 14:03:11 PST
The OpaqueJSClassContextData construction creates its own copy of key StringImpls using StringImpl::create(UChar) and characters(). Instead it should use StringImpl::isolatedCopy().
Attachments
Patch (2.28 KB, patch)
2012-11-07 14:05 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-11-07 14:05:24 PST
Created attachment 172867 [details] Patch
WebKit Review Bot
Comment 2 2012-11-08 06:55:09 PST
Comment on attachment 172867 [details] Patch Clearing flags on attachment: 172867 Committed r133894: <http://trac.webkit.org/changeset/133894>
WebKit Review Bot
Comment 3 2012-11-08 06:55:12 PST
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 4 2012-11-08 09:26:45 PST
Why?
Michael Saboff
Comment 5 2012-11-08 09:31:24 PST
(In reply to comment #4) > Why? isolatedCopy() will copy the string taking into account 8/16 bit. It is also better to have the object copy itself.
Note You need to log in before you can comment on or make changes to this bug.