Summary: | [chromium] Move to USE(LAZY_NATIVE_CURSOR) | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rick Byers <rbyers> | ||||||||||||||||
Component: | Platform | Assignee: | Rick Byers <rbyers> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | abarth, cc-bugs, dglazkov, gtk-ews, gustavo, jamesr, philn, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Bug Depends on: | 100550 | ||||||||||||||||||
Bug Blocks: | 100059 | ||||||||||||||||||
Attachments: |
|
Description
Rick Byers
2012-11-07 12:28:18 PST
Created attachment 173047 [details]
Patch
This actually turned out very nicely. We can simplify things by removing PlatformCursor on chromium entirely - USE(LAZY_NATIVE_CURSOR) gives us effectively the same thing but in a simple fashion that is unified with most other ports: a copy of the cursor information that will eventually be used to construct a real OS cursor (but in Chromium's case this isn't done until the data is passed to the browser process). However I believe this has the side effective of changing at least some cursor behavior, in particular fixing bug 100059. So I don't think we should make this change until there are tests in place. I'll work on landing bug 100550 for the other ports that already have USE(LAZY_NATIVE_CURSOR) first. Comment on attachment 173047 [details]
Patch
Looks great!
Created attachment 173176 [details]
Combined with fix for 100550 for EWS
Comment on attachment 173176 [details] Combined with fix for 100550 for EWS Attachment 173176 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14771465 Comment on attachment 173176 [details] Combined with fix for 100550 for EWS Attachment 173176 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14775347 Comment on attachment 173176 [details] Combined with fix for 100550 for EWS Attachment 173176 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14779175 Comment on attachment 173176 [details] Combined with fix for 100550 for EWS Attachment 173176 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14763871 Comment on attachment 173176 [details] Combined with fix for 100550 for EWS Attachment 173176 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14780102 Created attachment 173375 [details]
Merge with ToT
Created attachment 173376 [details]
Combined with fix for 100550 for EWS
Comment on attachment 173375 [details]
Merge with ToT
This looks great.
Comment on attachment 173376 [details] Combined with fix for 100550 for EWS Attachment 173376 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14790306 Created attachment 173425 [details]
Patch for landing
Created attachment 173429 [details]
Fix bad merge - actually re-enable the test in chromium
Created attachment 173430 [details]
Patch for landing
Comment on attachment 173430 [details] Patch for landing Clearing flags on attachment: 173430 Committed r134149: <http://trac.webkit.org/changeset/134149> All reviewed patches have been landed. Closing bug. |