Summary: | [V8] IntrusiveDOMWrapperMap is no longer needed and can be deleted | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, haraken, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 101110 | ||||||
Attachments: |
|
Description
Adam Barth
2012-11-07 11:15:58 PST
Created attachment 172843 [details]
Patch
Comment on attachment 172843 [details] Patch Please feel encouraged to review this patch, but I'd like to wait for http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/intl2/report.html?history=150&rev=-1&graph=ws_single_peak_r to cycle before landing it so I can separate out any regressions from http://trac.webkit.org/changeset/133783 Comment on attachment 172843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172843&action=review > Source/WebCore/bindings/v8/DOMDataStore.cpp:79 > + object->clearWrapper(); ASSERT(!object->wrapper().IsEmpty()) ? > Source/WebCore/bindings/v8/DOMDataStore.h:66 > + return object->wrapper(); ASSERT(!object->wrapper().IsEmpty()) ? > Source/WebCore/bindings/v8/DOMDataStore.h:84 > protected: private: > > Source/WebCore/bindings/v8/DOMDataStore.h:84
> > protected:
>
> private:
Thanks. You made this same comment the first time around. I just forgot to re-apply it. :)
Comment on attachment 172843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172843&action=review >> Source/WebCore/bindings/v8/DOMDataStore.cpp:79 >> + object->clearWrapper(); > > ASSERT(!object->wrapper().IsEmpty()) ? clearWrapper already has that ASSERT: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/ScriptWrappable.h#L56 >> Source/WebCore/bindings/v8/DOMDataStore.h:66 >> + return object->wrapper(); > > ASSERT(!object->wrapper().IsEmpty()) ? It might be empty if the Node doesn't have a wrapper yet. Committed r133794: <http://trac.webkit.org/changeset/133794> |