| Summary: | [BlackBerry] Improper initialization of ANGLEResources | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | akaushik | ||||||||||||||||
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||
| Status: | RESOLVED INVALID | ||||||||||||||||||
| Severity: | Normal | CC: | burg, commit-queue, dino, fspacek, jfeldstein, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
akaushik
2012-11-07 10:49:25 PST
Created attachment 172838 [details]
proposed patch
Is this patch inverted? Also you didn't set r? Please write proper titles to your filed bugs. Fixed title. MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed. Created attachment 173645 [details]
Patch
Comment on attachment 173645 [details]
Patch
Please provide a ChangeLog.
Created attachment 173652 [details]
Patch
Comment on attachment 173652 [details]
Patch
Can you try to get this internally reviewed first? At least Yong and I do not know WebGL/ANGLE. Also any PR?
Comment on attachment 173652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173652&action=review > Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:-115 > - ANGLEResources.MaxDrawBuffers = 1; // Always set to 1 for OpenGL ES. > - ANGLEResources.OES_standard_derivatives = m_extensions->supports("GL_OES_standard_derivatives"); As Rob said. We need an internal reviewer with expertise of GL stuff. Also ANGLEResources doesn't look like a variable name in WebKit. Can you also rename it to angleResources? Created attachment 185811 [details]
Patch
Remove the review flag from akaushik's latest patch, if it is obsolete, please. Comment on attachment 185811 [details] Patch Clearing flags on attachment: 185811 Committed r141691: <http://trac.webkit.org/changeset/141691> Created attachment 186416 [details]
Updated ChangeLog
Comment on attachment 186416 [details] Updated ChangeLog Rejecting attachment 186416 [details] from review queue. jfeldstein@rim.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 186416 [details] Updated ChangeLog Rejecting attachment 186416 [details] from commit-queue. jfeldstein@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Created attachment 186418 [details]
Reformatted ChangeLog
Comment on attachment 186418 [details] Reformatted ChangeLog Rejecting attachment 186418 [details] from review queue. jfeldstein@rim.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 186418 [details] Reformatted ChangeLog Rejecting attachment 186418 [details] from commit-queue. jfeldstein@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Created attachment 186423 [details]
Patch
Comment on attachment 186423 [details] Patch Rejecting attachment 186423 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 186423, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp Hunk #1 FAILED at 118. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-commit-queue.appspot.com/results/17641034 Comment on attachment 173652 [details]
Patch
Oops, I just say Yong Li’s comment and realized that maybe I should not have reviewed this. Somebody from RIM can reverse me, but this has been in the review queue for a really long time.
Comment on attachment 173652 [details] Patch Rejecting attachment 173652 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 173652, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp Hunk #1 FAILED at 111. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1907002 |