Bug 101484 – Clean up confused use of Document::renderer and renderView

• Component: New Bugs
• Status: RESOLVED FIXED

[Elliott Sprehn]

Clean up confused use of Document::renderer and renderView

[Elliott Sprehn]

Created attachment 172828 [details]
Patch

[Ojan Vafai]

Comment on attachment 172828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172828&action=review

> Source/WebCore/dom/Element.cpp:652
> +    return document()->view()->contentsToScreen(renderer()->absoluteBoundingBoxRectIgnoringTransforms());

Don't you still need to grab the frameView()? I'm confused how this compiled.

[Elliott Sprehn]

Comment on attachment 172828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172828&action=review

>> Source/WebCore/dom/Element.cpp:652
>> +    return document()->view()->contentsToScreen(renderer()->absoluteBoundingBoxRectIgnoringTransforms());
> 
> Don't you still need to grab the frameView()? I'm confused how this compiled.

document()->view() is the FrameView! :) document()->renderView() is the RenderView. Alas we have so many views.

This code was crazy before because it expanded to:

renderer()->m_node->document()->renderView()->frameView() so we went out into the render tree only to come back to ourself through m_node and then to the document and back into the render tree and then finally to the frame view... it was the rube goldberg of methods.

[Ojan Vafai]

Comment on attachment 172828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172828&action=review

>>> Source/WebCore/dom/Element.cpp:652
>>> +    return document()->view()->contentsToScreen(renderer()->absoluteBoundingBoxRectIgnoringTransforms());
>> 
>> Don't you still need to grab the frameView()? I'm confused how this compiled.
> 
> document()->view() is the FrameView! :) document()->renderView() is the RenderView. Alas we have so many views.
> 
> This code was crazy before because it expanded to:
> 
> renderer()->m_node->document()->renderView()->frameView() so we went out into the render tree only to come back to ourself through m_node and then to the document and back into the render tree and then finally to the frame view... it was the rube goldberg of methods.

Oh right. I see. Lol.

[WebKit Review Bot]

Comment on attachment 172828 [details]
Patch

Clearing flags on attachment: 172828

Committed r133813: <http://trac.webkit.org/changeset/133813>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.