Bug 101467

Summary: [EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch v2 none

Mikhail Pozdnyakov
Reported 2012-11-07 06:58:20 PST
MiniBrowser layout fallback width should be set to zero so that it renders non viewport meta element sites as desktop browser.
Attachments
patch (5.99 KB, patch)
2012-11-07 07:37 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v2 (6.00 KB, patch)
2012-11-07 07:39 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-11-07 07:08:09 PST
I prefer we use a name more in sync with what Qt uses. And their docs :)
Mikhail Pozdnyakov
Comment 2 2012-11-07 07:37:18 PST
Created attachment 172800 [details] patch
Mikhail Pozdnyakov
Comment 3 2012-11-07 07:39:50 PST
Created attachment 172801 [details] patch v2 fixed API functions description.
Kenneth Rohde Christiansen
Comment 4 2012-11-07 07:41:24 PST
Comment on attachment 172801 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=172801&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:326 > + * Sets preferred minimum contents width which is used as default minimum contents width > + * for non viewport meta element sites. soon this will cover @viewport!
WebKit Review Bot
Comment 5 2012-11-07 08:04:31 PST
Comment on attachment 172801 [details] patch v2 Clearing flags on attachment: 172801 Committed r133761: <http://trac.webkit.org/changeset/133761>
WebKit Review Bot
Comment 6 2012-11-07 08:04:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.