Bug 101427

Summary: Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING
Product: WebKit Reporter: Vivek Galatage <vivekgalatage>
Component: New BugsAssignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: peavo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Vivek Galatage
Reported 2012-11-06 21:28:58 PST
Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING This will fix the broken win cairo build. The error thrown by win cairo build is: 8>####### COMPILING 3 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ########### 8>DrawingArea.cpp 8>c:\projects\buildslave\win-cairo-release\build\source\webkit2\webprocess\webpage\DrawingAreaImpl.h(71) : error C3668: 'WebKit::DrawingAreaImpl::graphicsLayerFactory' : method with override specifier 'override' did not override any base class methods 8>c:\projects\buildslave\win-cairo-release\build\source\webkit2\webprocess\webpage\DrawingAreaImpl.h(72) : error C3668: 'WebKit::DrawingAreaImpl::setRootCompositingLayer' : method with override specifier 'override' did not override any base class methods 8>c:\projects\buildslave\win-cairo-release\build\source\webkit2\webprocess\webpage\DrawingAreaImpl.h(73) : error C3668: 'WebKit::DrawingAreaImpl::scheduleCompositingLayerFlush' : method with override specifier 'override' did not override any base class methods
Attachments
Patch (2.61 KB, patch)
2012-11-06 21:34 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-11-06 21:34:53 PST
Created attachment 172715 [details] Patch
WebKit Review Bot
Comment 2 2012-11-06 22:46:27 PST
Comment on attachment 172715 [details] Patch Clearing flags on attachment: 172715 Committed r133724: <http://trac.webkit.org/changeset/133724>
WebKit Review Bot
Comment 3 2012-11-06 22:46:30 PST
All reviewed patches have been landed. Closing bug.
peavo
Comment 4 2012-11-12 06:04:00 PST
*** Bug 101059 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.