| Summary: | Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Remy Demarest <rdemarest> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, benjamin, mrowe, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Remy Demarest
2012-11-06 18:52:14 PST
Created attachment 172697 [details]
Patch
Comment on attachment 172697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172697&action=review Nice patch. I did not know about those annotations. > Source/WTF/ChangeLog:9 > + Defines CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, uses in function declarations. Ok, not a native English speaker here. :) Should Define and use really take a S? Is the subject implicit or something? (In reply to comment #2) > (From update of attachment 172697 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172697&action=review > > Nice patch. I did not know about those annotations. > > > Source/WTF/ChangeLog:9 > > + Defines CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, uses in function declarations. > > Ok, not a native English speaker here. :) > Should Define and use really take a S? Is the subject implicit or something? Same here, not a native speaker, but if you take the "patch" as the subject of the sentence, then the S makes sense. Though the second sentence might need a "uses them in function declarations". Comment on attachment 172697 [details] Patch > Same here, not a native speaker, but if you take the "patch" as the subject of the sentence, then the S makes sense. Though the second sentence might need a "uses them in function declarations". Okay :) Can you please just update the changelog? Created attachment 172854 [details]
Patch
I modified the grammar of the change log to make it more consistent.
Comment on attachment 172854 [details]
Patch
Thank you :)
Comment on attachment 172854 [details] Patch Clearing flags on attachment: 172854 Committed r133793: <http://trac.webkit.org/changeset/133793> All reviewed patches have been landed. Closing bug. |