Bug 101399

Summary: [BlackBerry] Crash in InRegionScrollerPrivate
Product: WebKit Reporter: gmak
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch yong.li.webkit: review+

gmak
Reported 2012-11-06 14:33:51 PST
As the tin says
Attachments
Patch (5.30 KB, patch)
2012-11-06 14:45 PST, gmak 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2012-11-12 09:18 PST, Rob Buis 		yong.li.webkit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
gmak
Comment 1 2012-11-06 14:45:41 PST
Created attachment 172656 [details] Patch
Rob Buis
Comment 2 2012-11-06 14:49:13 PST
Comment on attachment 172656 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-11-06 15:30:31 PST
Comment on attachment 172656 [details] Patch Clearing flags on attachment: 172656 Committed r133679: <http://trac.webkit.org/changeset/133679>
WebKit Review Bot
Comment 4 2012-11-06 15:30:34 PST
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 5 2012-11-07 06:19:13 PST
Comment on attachment 172656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172656&action=review Hi Gen! > Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp:65 > + // Add a pointer to the enclosing document as the pointer to layer or node along the way may become invalid. > + if (m_layer->enclosingElement()) > + m_document = m_layer->enclosingElement()->document(); > + do you know when that happens? where is it used?
gmak
Comment 6 2012-11-07 07:36:59 PST
Antonio - we had an unreproducable crash from our automatic bug logging system with a partial stack trace which ended here: BlackBerry::WebKit::WebPagePrivate::clearDocumentData (this=0x78b9d750, documentGoingAway=0x7a35aa38)
Antonio Gomes
Comment 7 2012-11-07 08:13:45 PST
Comment on attachment 172656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172656&action=review > Source/WebKit/blackberry/Api/InRegionScroller.cpp:105 > ASSERT(scrollableArea); > - Node* node = scrollableArea->layer()->enclosingElement(); > - if (node && node->document() == documentGoingAway) > + if (scrollableArea->document() == documentGoingAway) maybe the fix could be test Node::isInDocument (what ever the name is) first instead. But ok, will leave it as is :)
Rob Buis
Comment 8 2012-11-12 09:18:51 PST
Reopening to attach new patch.
Rob Buis
Comment 9 2012-11-12 09:18:54 PST
Created attachment 173656 [details] Patch
Rob Buis
Comment 10 2012-11-12 10:44:43 PST
Committed r134256: <http://trac.webkit.org/changeset/134256>
Note You need to log in before you can comment on or make changes to this bug.