REGRESSION(r133529): Caused 15% memory regression on Chromium page cyclers (Requested by jsbell|gardener on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/133529 broke the build:
Caused 15% memory regression on Chromium page cyclers (Requested by jsbell|gardener on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 172616 [details]
ROLLOUT of r133529

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Joshua Bell]

ojan provided more details in webkit.org/b/89235 but here's the terrifying graph:

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/intl2/report.html?rev=166210&graph=ws_single_peak_r&history=30

[WebKit Review Bot]

Comment on attachment 172616 [details]
ROLLOUT of r133529

Clearing flags on attachment: 172616

Committed r133644: <http://trac.webkit.org/changeset/133644>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Thank you Ojan, Joshua.

[Joshua Bell]

FYI, I forgot to revert an expectation change (that I added...) so r133630 needed to be reverted too (as part of 133647) - just watch out for that test being flaky if this whole thing is re-landed.