Summary: | [EFL]Drawing artifacts while resizing the view | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kalyan <kalyan.kondapally> | ||||||
Component: | WebKit EFL | Assignee: | Kalyan <kalyan.kondapally> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, jesus, kenneth, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 103271 | ||||||||
Bug Blocks: | 103105 | ||||||||
Attachments: |
|
Description
Kalyan
2012-11-05 18:33:44 PST
This is observed with AC enabled and using webkit2. Might be related to https://bugs.webkit.org/show_bug.cgi?id=103271 (In reply to comment #2) > Might be related to https://bugs.webkit.org/show_bug.cgi?id=103271 After the above bug fix, situation is far better. We don’t see any empty tiles but still there seems to be flicker issues Investigating the flicker issues. Will wait till 103428 is fixed to see if we still see the flicker while resizing the view Removing dependency on 103428 Created attachment 176942 [details]
Patch
Comment on attachment 176942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176942&action=review Nice! just a few nits > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:119 > +#if USE(ACCELERATED_COMPOSITING) > + , m_isResized(false) > +#endif m_pendingSurfaceResize > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:368 > + // Create a GL surface here not to give a chance to Evas to paint the empty GL surface. Create a GL surface here so that Evas has no chance of painting to an empty GL surface. > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:164 > + void setResized(bool resized) { m_isResized = resized; } setNeedsSurfaceResize() { m_pendingSurfaceResize = true; } > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:390 > - if (width && height) > - impl->createGLSurface(IntSize(width, height)); > + impl->setResized(true); impl->setNeedsSurfaceResize(true) Created attachment 176954 [details]
Patch
Comment on attachment 176954 [details] Patch Clearing flags on attachment: 176954 Committed r136234: <http://trac.webkit.org/changeset/136234> All reviewed patches have been landed. Closing bug. |