Bug 101263 – AX: MathML types need to be semantically identified in AX tree

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

We need to expose the semantic MathML types through the AX tree so that screen readers can effectively output math equations.

rdar://12637680

[chris fleizach]

Created attachment 172414 [details]
patch

[chris fleizach]

Created attachment 172432 [details]
patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 172432 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebCore/rendering/mathml/RenderMathMLFenced.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 172432 [details]
patch

Attachment 172432 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14745225

[Early Warning System Bot]

Comment on attachment 172432 [details]
patch

Attachment 172432 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14726781

[chris fleizach]

Created attachment 172447 [details]
patch

[Dominic Mazzoni]

Comment on attachment 172447 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172447&action=review

Unofficial review looks good.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:251
> +        if (r->node()->isElementNode() && toElement(r->node())->isMathMLElement())

Should this line be in #if ENABLE(MATHML)? Have you tested compiling with and without this flag?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1197
> +    if (isIgnoredElementWithinMathTree())

It's unfortunate to have to add yet another method that walks the whole parent chain every time accessibilityIsIgnored is called - but we can try to improve this in another change.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2433
> +    if (isMathElement())

#if ENABLE(MATHML)

[chris fleizach]

(In reply to comment #8)
> (From update of attachment 172447 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172447&action=review
> 
> Unofficial review looks good.
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:251
> > +        if (r->node()->isElementNode() && toElement(r->node())->isMathMLElement())
> 
> Should this line be in #if ENABLE(MATHML)? Have you tested compiling with and without this flag?
> 

Doing so now

> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1197
> > +    if (isIgnoredElementWithinMathTree())
> 
> It's unfortunate to have to add yet another method that walks the whole parent chain every time accessibilityIsIgnored is called - but we can try to improve this in another change.

https://bugs.webkit.org/show_bug.cgi?id=101370

> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2433
> > +    if (isMathElement())
> 
> #if ENABLE(MATHML)

This one is actually OK since isMathElement() is just on AXObject and returns false by default without any MathML requirements

[Beth Dakin]

Comment on attachment 172447 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172447&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3548
> +    if (node()->hasTagName(MathMLNames::munderTag) || node()->hasTagName(MathMLNames::munderoverTag))

Do you need to null-check node() here?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3563
> +    if (node()->hasTagName(MathMLNames::moverTag))

Do you need to null-check node() here?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3593
> +    if (node()->hasTagName(MathMLNames::msubTag) || node()->hasTagName(MathMLNames::msubsupTag))

Do you need to null-check node() here?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3608
> +    if (node()->hasTagName(MathMLNames::msupTag))

Do you need to null-check node() here?

[chris fleizach]

http://trac.webkit.org/changeset/134496