Bug 101244

Summary: Back out controversial changes from Bug 98665
Product: WebKit Reporter: Dima Gorbik <dgorbik>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, ddkilzer, joepeck, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed fix 0.1
ddkilzer: review-
Proposed fix 0.2 none

Description Dima Gorbik 2012-11-05 12:13:42 PST
Back out controversial changes from Bug 98665 (https://bugs.webkit.org/show_bug.cgi?id=98665) until further discussions take place on rules for including Platform.h in Assertions.h
Comment 1 Dima Gorbik 2012-11-05 13:37:09 PST
Created attachment 172392 [details]
Proposed fix 0.1
Comment 2 WebKit Review Bot 2012-11-05 13:43:53 PST
Attachment 172392 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/tests/minidom.c'..." exit_code: 1
Source/WTF/wtf/Assertions.h:46:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2012-11-05 14:10:21 PST
Comment on attachment 172392 [details]
Proposed fix 0.1

View in context: https://bugs.webkit.org/attachment.cgi?id=172392&action=review

> Tools/DumpRenderTree/mac/MockGeolocationProvider.mm:26
> +#include "config.h"

Usually we use #import here instead of #include.
Comment 4 Dima Gorbik 2012-11-05 14:12:06 PST
Created attachment 172402 [details]
Proposed fix 0.2
Comment 5 WebKit Review Bot 2012-11-05 14:19:51 PST
Attachment 172402 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/tests/minidom.c'..." exit_code: 1
Source/WTF/wtf/Assertions.h:46:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 David Kilzer (:ddkilzer) 2012-11-05 14:40:29 PST
Comment on attachment 172402 [details]
Proposed fix 0.2

r=me
Comment 7 WebKit Review Bot 2012-11-05 15:10:32 PST
Comment on attachment 172402 [details]
Proposed fix 0.2

Clearing flags on attachment: 172402

Committed r133533: <http://trac.webkit.org/changeset/133533>
Comment 8 WebKit Review Bot 2012-11-05 15:10:36 PST
All reviewed patches have been landed.  Closing bug.