Bug 101230

Summary: Style-checker strips comments before checking indentation
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: NEW    
Severity: Normal CC: abarth, ahmad.saleem792, ap, dpranke, gsnedders, levin, ryanhaddad, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tony: review+, allan.jensen: commit-queue-

Allan Sandfeld Jensen
Reported 2012-11-05 09:36:26 PST
The style-checker performs its indentation check on cleansed lines, this means that comments are not checked for indentation, and inline comments followed by white-space will be miscounted by style-checker. Instead the style-checker should perform indentation check on raw-lines. This way it will also ensure comments correctly indented.
Attachments
Patch (1.89 KB, patch)
2012-11-05 09:38 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2012-11-06 02:35 PST, Allan Sandfeld Jensen 		tony: review+
allan.jensen: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-11-05 09:38:46 PST
Created attachment 172353 [details] Patch
Adam Barth
Comment 2 2012-11-05 10:07:29 PST
Comment on attachment 172353 [details] Patch Please add a test. There's a nice unit testing framework for this code.
Allan Sandfeld Jensen
Comment 3 2012-11-06 02:35:25 PST
Created attachment 172531 [details] Patch
Allan Sandfeld Jensen
Comment 4 2012-11-09 06:38:06 PST
Comment on attachment 172531 [details] Patch I want to run a one more test on this patch before landing. I am uncertain if multi-line comments are correctly handled, or might give false errors.
Ahmad Saleem
Comment 5 2022-10-25 08:48:03 PDT
It seems this r+ patch didn't landed. Is this needed now to enhance "Style-checker" or this is already taken care of one way or another? Thanks!
Note You need to log in before you can comment on or make changes to this bug.