Bug 101230

Summary: Style-checker strips comments before checking indentation
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: NEW ---    
Severity: Normal CC: abarth, dpranke, levin, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tony: review+, allan.jensen: commit-queue-

Description Allan Sandfeld Jensen 2012-11-05 09:36:26 PST
The style-checker performs its indentation check on cleansed lines, this means that comments are not checked for indentation, and inline comments followed by white-space will be miscounted by style-checker. 

Instead the style-checker should perform indentation check on raw-lines. This way it will also ensure comments correctly indented.
Comment 1 Allan Sandfeld Jensen 2012-11-05 09:38:46 PST
Created attachment 172353 [details]
Patch
Comment 2 Adam Barth 2012-11-05 10:07:29 PST
Comment on attachment 172353 [details]
Patch

Please add a test.  There's a nice unit testing framework for this code.
Comment 3 Allan Sandfeld Jensen 2012-11-06 02:35:25 PST
Created attachment 172531 [details]
Patch
Comment 4 Allan Sandfeld Jensen 2012-11-09 06:38:06 PST
Comment on attachment 172531 [details]
Patch

I want to run a one more test on this patch before landing. I am uncertain if multi-line comments are correctly handled, or might give false errors.