Summary: | Style-checker strips comments before checking indentation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||||
Component: | Tools / Tests | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||||
Status: | NEW --- | ||||||||
Severity: | Normal | CC: | abarth, ahmad.saleem792, ap, dpranke, gsnedders, levin, ryanhaddad, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Allan Sandfeld Jensen
2012-11-05 09:36:26 PST
Created attachment 172353 [details]
Patch
Comment on attachment 172353 [details]
Patch
Please add a test. There's a nice unit testing framework for this code.
Created attachment 172531 [details]
Patch
Comment on attachment 172531 [details]
Patch
I want to run a one more test on this patch before landing. I am uncertain if multi-line comments are correctly handled, or might give false errors.
It seems this r+ patch didn't landed. Is this needed now to enhance "Style-checker" or this is already taken care of one way or another? Thanks! |