Bug 101203

Summary: [EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, mrobinson, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-11-05 02:55:03 PST
EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after http://trac.webkit.org/changeset/133389. I will investigate to check what needs to be fixed.
Attachments
Patch (3.99 KB, patch)
2012-11-05 03:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-11-05 03:11:31 PST
The difference seems to be that ResourceHandle::receivedCancellation() is now calling ResourceHandleClient::receivedCancellation(). This apparently causes us not to get a "401 Unauthorized" error for the main resource anymore. Instead of seems to get a 302 provisional load error.
Chris Dumez
Comment 2 2012-11-05 03:27:44 PST
The GTK port calls receivedRequestToContinueWithoutCredential() by default instead of cancelling. I think the EFL port needs to do the same for the behavior to be the one we expected.
Chris Dumez
Comment 3 2012-11-05 03:43:02 PST
Created attachment 172307 [details] Patch This fixes the API test and makes us behave like GTK port.
WebKit Review Bot
Comment 4 2012-11-05 04:15:25 PST
Comment on attachment 172307 [details] Patch Clearing flags on attachment: 172307 Committed r133455: <http://trac.webkit.org/changeset/133455>
WebKit Review Bot
Comment 5 2012-11-05 04:15:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.