Bug 101177

Summary: Robohornet SVG benchmark spends too much time in unnecessary repaint checks.
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, eric, fmalita, gyuyoung.kim, krit, rakuco, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First pass
eric: review+
Patch for landing
pdr: commit-queue+
Path for landing (2) none

Description Philip Rogers 2012-11-04 21:04:51 PST 
The repaint box calculations are multiplying the local repaint bounding box quad through 5 matrices on every update of the benchmark (for each of hundreds of shapes). Only local bounding boxes are stored in our SVG implementation but we should be able to cache some of this.

Patch forthcoming!
Comment 1 Dirk Schulze 2012-11-05 06:02:44 PST 
Link please.
Comment 2 Philip Rogers 2012-11-05 09:58:34 PST 
http://www.robohornet.org/#et=svg
Comment 3 Philip Rogers 2012-11-06 17:27:11 PST 
Created attachment 172681 [details]
First pass
Comment 4 WebKit Review Bot 2012-11-06 17:30:17 PST 
Attachment 172681 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/qt/TestExpectations:2394:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Seidel (no email) 2012-11-06 17:48:51 PST 
Comment on attachment 172681 [details]
First pass

SGTM!
Comment 6 Philip Rogers 2012-11-07 10:37:45 PST 
Created attachment 172834 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-11-07 10:40:25 PST 
Attachment 172834 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/qt/TestExpectations:2394:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Philip Rogers 2012-11-07 10:42:46 PST 
Created attachment 172835 [details]
Path for landing (2)
Comment 9 WebKit Review Bot 2012-11-07 11:27:25 PST 
Comment on attachment 172835 [details]
Path for landing (2)

Clearing flags on attachment: 172835

Committed r133786: <http://trac.webkit.org/changeset/133786>
Comment 10 WebKit Review Bot 2012-11-07 11:27:29 PST 
All reviewed patches have been landed.  Closing bug.