| Summary: | [EFL] Use _LIBRARIES instead of _LIBRARY | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Halton Huo <halton.huo> | ||||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 172031 [details]
Patch
Comment on attachment 172031 [details]
Patch
Looks OK, but the ChangeLog really deserves a more detailed explanation (it's not that "LIBRARIES" is more common than "LIBRARY", but rather that the latter is intended for internal use in those two Find files).
Please prefix titles for port-specific patches with the port name, even if the component is port-specific too. Comment on attachment 172031 [details]
Patch
r- as Raphael and Darin said.
Created attachment 172256 [details]
Patch
Comment on attachment 172256 [details]
Patch
Updated patch with addressing rakuco and Darin's comments on ChangeLog
Comment on attachment 172256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172256&action=review > Source/WebCore/ChangeLog:11 > + EFL port build pass I think this comment is not needed. > Source/WebKit/ChangeLog:11 > + EFL port build pass ditto. > Source/WebKit2/ChangeLog:11 > + EFL port build pass ditto. Created attachment 172264 [details]
Patch
Comment on attachment 172264 [details] Patch Clearing flags on attachment: 172264 Committed r133432: <http://trac.webkit.org/changeset/133432> All reviewed patches have been landed. Closing bug. |
In PlatformEfl.cmake, JPEG_LIBRARY is used to add jpeg lib. Since For modules under /usr/share/cmake/Modules, xxx_LIBRARIES is more common used than xxx_LIBRARY. Other libs like ${ICU_LIBRARIES} and ${LIBXML2_LIBRARIES} are all use xxx_LIBRARIES. So I'd like to make a change to use _LIBRARIES instead.