Bug 101042

Summary:

[EFL] Use _LIBRARIES instead of _LIBRARY

Product:

WebKit

Reporter:

Halton Huo <halton.huo>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Halton Huo

Reported 2012-11-02 04:03:06 PDT

In PlatformEfl.cmake, JPEG_LIBRARY is used to add jpeg lib. Since For modules under /usr/share/cmake/Modules, xxx_LIBRARIES is more common used than xxx_LIBRARY. Other libs like ${ICU_LIBRARIES} and ${LIBXML2_LIBRARIES} are all use xxx_LIBRARIES. So I'd like to make a change to use _LIBRARIES instead.

Attachments
Patch (3.54 KB, patch) 2012-11-02 04:18 PDT, Halton Huo	no flags	Details Formatted Diff Diff
Patch (3.82 KB, patch) 2012-11-04 18:50 PST, Halton Huo	no flags	Details Formatted Diff Diff
Patch (3.73 KB, patch) 2012-11-04 20:55 PST, Halton Huo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Halton Huo

Comment 1 2012-11-02 04:18:37 PDT

Created attachment 172031 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2012-11-02 05:15:07 PDT

Comment on attachment 172031 [details] Patch Looks OK, but the ChangeLog really deserves a more detailed explanation (it's not that "LIBRARIES" is more common than "LIBRARY", but rather that the latter is intended for internal use in those two Find files).

Darin Adler

Comment 3 2012-11-02 09:59:18 PDT

Please prefix titles for port-specific patches with the port name, even if the component is port-specific too.

Gyuyoung Kim

Comment 4 2012-11-03 23:44:37 PDT

Comment on attachment 172031 [details] Patch r- as Raphael and Darin said.

Halton Huo

Comment 5 2012-11-04 18:50:20 PST

Created attachment 172256 [details] Patch

Halton Huo

Comment 6 2012-11-04 18:53:13 PST

Comment on attachment 172256 [details] Patch Updated patch with addressing rakuco and Darin's comments on ChangeLog

Gyuyoung Kim

Comment 7 2012-11-04 20:07:55 PST

Comment on attachment 172256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172256&action=review > Source/WebCore/ChangeLog:11 > + EFL port build pass I think this comment is not needed. > Source/WebKit/ChangeLog:11 > + EFL port build pass ditto. > Source/WebKit2/ChangeLog:11 > + EFL port build pass ditto.

Halton Huo

Comment 8 2012-11-04 20:55:30 PST

Created attachment 172264 [details] Patch

WebKit Review Bot

Comment 9 2012-11-04 21:34:20 PST

Comment on attachment 172264 [details] Patch Clearing flags on attachment: 172264 Committed r133432: <http://trac.webkit.org/changeset/133432>

WebKit Review Bot

Comment 10 2012-11-04 21:34:24 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.