Bug 100936 – Web Inspector: Timeline: Improve time/timeEnd appearance.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

time/timeEnd records should be top level records only in "glue" mode.

Also fixed minor bugs:
- glued records add aggregated statistics to root record
- glued records do not reduce their origin self time

Created attachment 171803 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 171803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171803&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:354
> +        if (!origin.isRoot()) {
> +            origin.selfTime -= formattedRecord.endTime - formattedRecord.startTime;

Why would we do this for adopted records? Shouldn't it be under if (origin) {} else?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:623
> +    getOrigin: function()

origin()

Comment on attachment 171803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171803&action=review

>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:354
>> +            origin.selfTime -= formattedRecord.endTime - formattedRecord.startTime;
> 
> Why would we do this for adopted records? Shouldn't it be under if (origin) {} else?

There are two cases:
1) record is own record of its parent: in that case parent self time must be reduced (because self time is time delta minus all children time delta)
2) record is adopted: in that case origin record self time must be reduced (for the same reasons)

This way - in both cases we must reduce self time record of "parent" record. But for adopted records the correct target is origin.

>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:623
>> +    getOrigin: function()
> 
> origin()

Done

Created attachment 171844 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 171844 [details]
Patch

LGTM

[WebKit Review Bot]

Comment on attachment 171844 [details]
Patch

Clearing flags on attachment: 171844

Committed r133863: <http://trac.webkit.org/changeset/133863>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.