Bug 100868

Summary: [BlackBerry] Adding window.external to our port
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

otcheung
Reported 2012-10-31 11:08:38 PDT
Adding the window.external interface to the blackberry port.
Attachments
Patch (13.01 KB, patch)
2012-10-31 11:22 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (16.06 KB, patch)
2012-10-31 11:30 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2012-11-02 07:28 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (1.64 KB, patch)
2012-11-06 07:50 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-10-31 11:22:05 PDT
Created attachment 171692 [details] Patch
otcheung
Comment 2 2012-10-31 11:30:51 PDT
Created attachment 171695 [details] Patch
Rob Buis
Comment 3 2012-10-31 11:35:02 PDT
Comment on attachment 171695 [details] Patch LGTM
WebKit Review Bot
Comment 4 2012-10-31 16:27:26 PDT
Comment on attachment 171695 [details] Patch Clearing flags on attachment: 171695 Committed r133094: <http://trac.webkit.org/changeset/133094>
WebKit Review Bot
Comment 5 2012-10-31 16:27:30 PDT
All reviewed patches have been landed. Closing bug.
otcheung
Comment 6 2012-11-02 07:28:55 PDT
Reopening to attach new patch.
otcheung
Comment 7 2012-11-02 07:28:59 PDT
Created attachment 172058 [details] Patch
Rob Buis
Comment 8 2012-11-02 07:39:37 PDT
Comment on attachment 172058 [details] Patch Ok.
WebKit Review Bot
Comment 9 2012-11-02 10:47:18 PDT
Comment on attachment 172058 [details] Patch Clearing flags on attachment: 172058 Committed r133314: <http://trac.webkit.org/changeset/133314>
WebKit Review Bot
Comment 10 2012-11-02 10:47:24 PDT
All reviewed patches have been landed. Closing bug.
otcheung
Comment 11 2012-11-06 07:50:30 PST
Reopening to attach new patch.
otcheung
Comment 12 2012-11-06 07:50:33 PST
Created attachment 172587 [details] Patch
Rob Buis
Comment 13 2012-11-06 07:54:48 PST
Comment on attachment 172587 [details] Patch LGTM.
WebKit Review Bot
Comment 14 2012-11-06 10:25:29 PST
Comment on attachment 172587 [details] Patch Clearing flags on attachment: 172587 Committed r133634: <http://trac.webkit.org/changeset/133634>
WebKit Review Bot
Comment 15 2012-11-06 10:25:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.