Bug 10086

Summary: Regression: Drawing SVG lighting filters is broken
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2 Keywords: Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-filters-light-01-f.html
Attachments:
Description Flags
patch where something goes wrong none

Eric Seidel (no email)
Reported 2006-07-24 00:45:14 PDT
Regression: Drawing SVG lighting filters is broken This is seen on refresh: 2006-07-24 03:43:30.562 Safari[15847] unlockFocus called too many time. 2006-07-24 03:43:30.564 Safari[15847] unlockFocus called too many time.
Attachments
patch where something goes wrong (32.38 KB, patch)
2006-07-24 00:54 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2006-07-24 00:51:59 PDT
This also breaks text layout for the first row. This is a regression caused by patch 14918
Eric Seidel (no email)
Comment 2 2006-07-24 00:52:38 PDT
This was caused by http://bugzilla.opendarwin.org/show_bug.cgi?id=9488 according to oliver.
Oliver Hunt
Comment 3 2006-07-24 00:54:04 PDT
Created attachment 9647 [details] patch where something goes wrong Not for review, something in this caused the badness
Oliver Hunt
Comment 4 2006-07-24 07:08:35 PDT
Okles the change to WebCore::RenderSVGImage::relativeBBox causes the layout to be bludgeoned.
Oliver Hunt
Comment 5 2006-07-26 07:11:13 PDT
and in fact the patch does only bludgeon layout -- there are a couple of crashes, possibly with the same root cause. I am now stepping back by ever increasing amounts, and scrolling with the above url is still crashing at revision 14700
Oliver Hunt
Comment 6 2006-07-26 07:32:13 PDT
Alex pointed out on IRC that the crash may in fact be a regression triggered by the 10.4.7 update -- anyone got a 10.4.6 box available?
Oliver Hunt
Comment 7 2006-08-11 06:46:49 PDT
Okay am splitting the layout bug out of this one...
Eric Seidel (no email)
Comment 8 2007-10-01 08:49:45 PDT
It seems WildFox has fixed lighting filters on feature-branch, except perhaps for spotlight filters.
Note You need to log in before you can comment on or make changes to this bug.