Bug 10083

Summary: REGRESSION (r15584): editing/selection/select-from-textfield-outwards failing
Product: WebKit Reporter: mitz
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alice.barraclough, darin
Priority: P1 Keywords: Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Add back the code that was removed darin: review+

mitz
Reported 2006-07-23 22:34:17 PDT
The fix for <rdar://problem/4617841> removed part of the fix for bug 9312, causing editing/selection/select-from-textfield-outwards.html to fail: -    if (isReplaced()) { -        if (y < absy || y < absy + height() && x < absx) -            return VisiblePosition(n, caretMinOffset(), DOWNSTREAM); -        if (y >= absy + height() || y >= absy && x >= absx + width()) -            return VisiblePosition(n, caretMaxOffset(), DOWNSTREAM); -    }  You can see the problem by opening the test case from bug 9312 (attachment 8713 [details]) and dragging from the middle of the text field and to the right. As you exit the field, the selection changes (starts at the beginning of the text field instead of going from the middle to the end).
Attachments
Add back the code that was removed (1.71 KB, patch)
2006-07-23 23:07 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-07-23 23:07:04 PDT
Created attachment 9644 [details] Add back the code that was removed
Timothy Hatcher
Comment 2 2006-07-24 08:36:58 PDT
This has been landed on the branch in r15596.
Timothy Hatcher
Comment 3 2006-07-24 08:38:56 PDT
This has landed on TOT in r15597.
Note You need to log in before you can comment on or make changes to this bug.