Summary: | [EFL] CMake shows ENABLE_3D_RENDERING and ENABLE_WEBGL is still OFF when AC is enabled | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joone Hur <joone> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, halton.huo, lucas.de.marchi, paroga, rakuco, tmpsantos, webkit.review.bot, yael | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Joone Hur
2012-10-31 01:34:02 PDT
Created attachment 171598 [details]
patch
Comment on attachment 171598 [details]
patch
Simply moving the call to WEBKIT_OPTION_END() to the end of the file in OptionsEfl.cmake should solve the problem in a cleaner way.
(In reply to comment #2) > (From update of attachment 171598 [details]) > Simply moving the call to WEBKIT_OPTION_END() to the end of the file in OptionsEfl.cmake should solve the problem in a cleaner way. I tried, but it doesn't work. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 171598 [details] [details]) > > Simply moving the call to WEBKIT_OPTION_END() to the end of the file in OptionsEfl.cmake should solve the problem in a cleaner way. > > I tried, but it doesn't work. That's probably because of the interaction between normal variables and cache variables in CMake. SET(ENABLE_WEBGL 1) in OptionsEfl.cmake sets a normal variable, and later the call to OPTION(ENABLE_WEBGL ...) will set a cache variable with the same name and remove the original normal variable. I think the cleanest solution here is to move the call to WEBKIT_OPTION_END() to the end of OptionEfl.cmake and modify the macro so that the initial value it uses in the OPTION() call is the value of the variable itself if it is defined, and the initial value otherwise. This would still require you to clean up your cache nonetheless, as CMake by default won't change the options you already have in your cache when you call a command such as OPTION(). Patrick, what do you think? *** Bug 102903 has been marked as a duplicate of this bug. *** How about my patch for the dup bug 102903? it works as wish. could somebody assign this bug to me so that i can add upload patch. Created attachment 175555 [details]
Patch
Anyone could review? Joone, Gyuyoung? Comment on attachment 175555 [details]
Patch
Hmm, WebKit doesn't like that a bug lands multiple patches. I think you guys need to merge these patches into a patch.
Kim, as joone said on comment #3, first patch does not work. The second one I uploaded works well, not need with first patch. Comment on attachment 175555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175555&action=review I think rakuco might to take a final look. > ChangeLog:4 > + AC is enabled It looks this is unneeded line change. Created attachment 175634 [details]
Patch
(In reply to comment #12) > Created an attachment (id=175634) [details] > Patch Update patch addressing Gyuyoung's comment at #11 Comment on attachment 175634 [details] Patch Clearing flags on attachment: 175634 Committed r135813: <http://trac.webkit.org/changeset/135813> All reviewed patches have been landed. Closing bug. |