Bug 100825

Summary: DFG optimized string access code should be enabled
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2012-10-31 01:06:30 PDT
The DFG string access code kicks in only when the 'this' operand has a string prediction during parsing. That will never happen. No operand has any predictions during parsing. Parsing doesn't have predictions. Predictions don't exist until after prediction propagation runs. Prediction propagation runs only after parsing completely finishes. So, we should remove prediction checks from the code in the parser that recognizes string intrinsics.
Attachments
the patch (8.50 KB, patch)
2012-10-31 01:13 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-10-31 01:13:29 PDT
Created attachment 171593 [details] the patch
Filip Pizlo
Comment 2 2012-11-01 00:42:45 PDT
Landed in http://trac.webkit.org/changeset/133135
Note You need to log in before you can comment on or make changes to this bug.