Bug 100811

Summary: [CSS Exclusions] Optimize style change for shape outside info to do deep equals
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: betravis, eric, ojan.autocc, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css3-exclusions/
Attachments:
Description Flags
Patch to update comment none

Bem Jones-Bey
Reported 2012-10-30 21:36:01 PDT
Doing a deep equality comparison in RenderBox::updateExclusionShapeOutsideInfoAfterStyleChange will make it so that it does not have to recreate the shape in as many situations.
Attachments
Patch to update comment (1.67 KB, patch)
2013-02-12 14:55 PST, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2012-11-05 10:55:05 PST
I think this is a dupe of bug 92164
Bem Jones-Bey
Comment 2 2013-02-12 14:55:24 PST
Created attachment 187942 [details] Patch to update comment You're right, it is a dup. Updating the comment in the code to point to bug 92164.
Nico Weber
Comment 3 2013-02-12 15:07:30 PST
I think it's enough to just mark the bug as dupe. The 3 people who follow the link from the bug can just click through. *** This bug has been marked as a duplicate of bug 92164 ***
Note You need to log in before you can comment on or make changes to this bug.