Bug 100761

Summary: Web Inspector: Timeline: make "addRecord" unambiguous
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, eustas.bug, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 99830    
Attachments:
Description Flags
Patch none

eustas.bug
Reported 2012-10-30 07:54:19 PDT
TimelinePresentationModel.addRecord accepts two parameters - record and parentRecord. parentRecord is always root record, but that is not clear.
Attachments
Patch (3.76 KB, patch)
2012-10-30 07:58 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-10-30 07:58:08 PDT
Created attachment 171451 [details] Patch
Andrey Kosyakov
Comment 2 2012-10-30 08:15:33 PDT
Comment on attachment 171451 [details] Patch LGTM
WebKit Review Bot
Comment 3 2012-10-31 02:47:25 PDT
Comment on attachment 171451 [details] Patch Rejecting attachment 171451 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12787. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14687094
WebKit Review Bot
Comment 4 2012-11-01 06:50:52 PDT
Comment on attachment 171451 [details] Patch Clearing flags on attachment: 171451 Committed r133157: <http://trac.webkit.org/changeset/133157>
WebKit Review Bot
Comment 5 2012-11-01 06:50:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.