Bug 100752

Summary:

Web Inspector: [Canvas] do not blow up the capturing log

Product:

WebKit

Reporter:

Andrey Adaikin <aandrey>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Adaikin <aandrey>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+, buildbot: commit-queue-
fixed test for bots	buildbot: commit-queue-
fixed jscompiler warnings	buildbot: commit-queue-
fixed mac test	none

Andrey Adaikin

Reported 2012-10-30 06:28:38 PDT

Clear obsolete calls in the canvas 2D capturing log in runtime. Patch to follow.

Attachments
Patch (36.87 KB, patch) 2012-10-30 06:51 PDT, Andrey Adaikin	pfeldman: review+ buildbot: commit-queue-	Details Formatted Diff Diff
fixed test for bots (37.17 KB, patch) 2012-11-01 01:27 PDT, Andrey Adaikin	buildbot: commit-queue-	Details Formatted Diff Diff
fixed jscompiler warnings (38.62 KB, patch) 2012-11-01 01:45 PDT, Andrey Adaikin	buildbot: commit-queue-	Details Formatted Diff Diff
fixed mac test (38.86 KB, patch) 2012-11-02 08:42 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Adaikin

Comment 1 2012-10-30 06:51:30 PDT

Created attachment 171440 [details] Patch

Build Bot

Comment 2 2012-10-30 12:10:24 PDT

Comment on attachment 171440 [details] Patch Attachment 171440 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14625684 New failing tests: inspector/profiler/canvas2d/canvas2d-api-changes.html

Andrey Adaikin

Comment 3 2012-11-01 01:27:41 PDT

Created attachment 171791 [details] fixed test for bots

Andrey Adaikin

Comment 4 2012-11-01 01:45:44 PDT

Created attachment 171797 [details] fixed jscompiler warnings

Build Bot

Comment 5 2012-11-01 02:00:18 PDT

Comment on attachment 171791 [details] fixed test for bots Attachment 171791 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14661539 New failing tests: inspector/profiler/canvas2d/canvas2d-api-changes.html

Build Bot

Comment 6 2012-11-01 03:42:00 PDT

Comment on attachment 171797 [details] fixed jscompiler warnings Attachment 171797 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14697246 New failing tests: inspector/profiler/canvas2d/canvas2d-api-changes.html

Andrey Adaikin

Comment 7 2012-11-02 08:42:55 PDT

Created attachment 172066 [details] fixed mac test

WebKit Review Bot

Comment 8 2012-11-04 23:11:59 PST

Comment on attachment 172066 [details] fixed mac test Rejecting attachment 172066 [details] from commit-queue. aandrey@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Review Bot

Comment 9 2012-11-04 23:53:19 PST

Comment on attachment 172066 [details] fixed mac test Clearing flags on attachment: 172066 Committed r133438: <http://trac.webkit.org/changeset/133438>

Brian Burg

Comment 10 2014-12-12 13:39:57 PST

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.

Note You need to log in before you can comment on or make changes to this bug.