Bug 100694

Summary:

[BlackBerry] Web page view state should be preserved for pages loaded from page cache

Product:

WebKit

Reporter:

Michael Matovsky <mmatovsky.webkit>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

joenotcharles, liachen, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add logic to persist web view state in page cache.	rwlbuis: review-
Add logic to persist web view state in page cache.	none
Add logic to persist web view state in page cache.	none
Add logic to persist web view state in page cache.	none

Michael Matovsky

Reported 2012-10-29 13:36:09 PDT

The web page view specific metadata should be preserved for web pages pages loaded from page cache (by using back/forward). This requires web page view state to be saved in and restored from the corresponding page cache history item.

Attachments
Add logic to persist web view state in page cache. (2.91 KB, patch) 2012-10-29 14:15 PDT, Michael Matovsky	rwlbuis: review-	Details Formatted Diff Diff
Add logic to persist web view state in page cache. (4.08 KB, patch) 2012-10-31 12:59 PDT, Michael Matovsky	no flags	Details Formatted Diff Diff
Add logic to persist web view state in page cache. (4.96 KB, patch) 2012-10-31 14:06 PDT, Michael Matovsky	no flags	Details Formatted Diff Diff
Add logic to persist web view state in page cache. (5.15 KB, patch) 2012-10-31 15:47 PDT, Michael Matovsky	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Michael Matovsky

Comment 1 2012-10-29 14:15:31 PDT

Created attachment 171312 [details] Add logic to persist web view state in page cache.

Rob Buis

Comment 2 2012-10-30 08:39:38 PDT

Comment on attachment 171312 [details] Add logic to persist web view state in page cache. This patch needs a ChangeLog.

Michael Matovsky

Comment 3 2012-10-31 12:59:06 PDT

Created attachment 171707 [details] Add logic to persist web view state in page cache.

Michael Matovsky

Comment 4 2012-10-31 13:20:20 PDT

Comment on attachment 171707 [details] Add logic to persist web view state in page cache. Please ignore this patch, I forgot the ChangeLog again.

Michael Matovsky

Comment 5 2012-10-31 14:06:21 PDT

Created attachment 171715 [details] Add logic to persist web view state in page cache. Including the ChangeLog

Michael Matovsky

Comment 6 2012-10-31 15:47:53 PDT

Created attachment 171734 [details] Add logic to persist web view state in page cache. The patch should now be in the right format. Please review.

Rob Buis

Comment 7 2012-11-01 09:27:29 PDT

Comment on attachment 171734 [details] Add logic to persist web view state in page cache. LGTM.

WebKit Review Bot

Comment 8 2012-11-01 09:46:23 PDT

Comment on attachment 171734 [details] Add logic to persist web view state in page cache. Rejecting attachment 171734 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 154708. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14677590

WebKit Review Bot

Comment 9 2012-11-01 11:37:48 PDT

Comment on attachment 171734 [details] Add logic to persist web view state in page cache. Clearing flags on attachment: 171734 Committed r133199: <http://trac.webkit.org/changeset/133199>

WebKit Review Bot

Comment 10 2012-11-01 11:37:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.