Bug 100681

Summary:

[CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit EFL

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ggaren, gyuyoung.kim, haraken, kenneth, laszlo.gombos, lucas.de.marchi, paroga, rakuco, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2012-10-29 08:47:33 PDT

http://trac.webkit.org/changeset/132713 introduced a new test plugin (TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp) but failed to add it to CMake. As a consequence, the following test case is failing on EFL port: plugins/npruntime/npruntime-calls-with-null-npp.html

Attachments
Patch (1.66 KB, patch) 2012-10-29 09:37 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2012-10-29 09:37:43 PDT

Created attachment 171262 [details] Patch

Chris Dumez

Comment 2 2012-10-29 10:31:00 PDT

Failure on the bot that this patch is fixing: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132807%20%285208%29/plugins/npruntime/npruntime-calls-with-null-npp-pretty-diff.html

Anders Carlsson

Comment 3 2012-10-29 11:21:40 PDT

Comment on attachment 171262 [details] Patch Oops, sorry about that!

WebKit Review Bot

Comment 4 2012-10-29 11:50:30 PDT

Comment on attachment 171262 [details] Patch Clearing flags on attachment: 171262 Committed r132831: <http://trac.webkit.org/changeset/132831>

WebKit Review Bot

Comment 5 2012-10-29 11:50:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.