Bug 100657

Summary: [CSSOM] Extraneous whitespace in CSSImportRule.cssText
Product: WebKit Reporter: Glenn Adams <glenn>
Component: CSSAssignee: Glenn Adams <glenn>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, dino, eric.carlson, feature-media-reviews, koivisto, macpherson, menard, seikwon.kim, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Glenn Adams
Reported 2012-10-29 05:03:38 PDT
According to CSSOM [1], when serializing CSSImportRule (as cssText), no whitespace should follow the url() when the media list is empty. At present, other common browsers (FF, Opera) follow this behavior. However, WK is returning an extra SPACE after the url() and before the final SEMICOLON when the media list is empty. An incoming CSSWG test for this behavior can be found at [2]. [1] http://dvcs.w3.org/hg/csswg/raw-file/tip/cssom/Overview.html#serialize-a-css-rule [2] http://test.csswg.org/source/contributors/gadams/incoming/cssom/cssimportrule-media.xht
Attachments
Patch (5.54 KB, patch)
2012-10-29 06:25 PDT, Glenn Adams 		no flags
DetailsFormatted DiffDiff
Patch (7.52 KB, patch)
2012-10-29 09:08 PDT, Glenn Adams 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Glenn Adams
Comment 1 2012-10-29 06:25:32 PDT
Created attachment 171224 [details] Patch
WebKit Review Bot
Comment 2 2012-10-29 07:24:14 PDT
Comment on attachment 171224 [details] Patch Attachment 171224 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14628129 New failing tests: http/tests/css/shared-stylesheet-mutation.html http/tests/css/shared-stylesheet-mutation-preconstruct.html
Build Bot
Comment 3 2012-10-29 07:57:04 PDT
Comment on attachment 171224 [details] Patch Attachment 171224 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14623338 New failing tests: http/tests/css/shared-stylesheet-mutation.html http/tests/css/shared-stylesheet-mutation-preconstruct.html
Glenn Adams
Comment 4 2012-10-29 09:08:24 PDT
Created attachment 171255 [details] Patch
WebKit Review Bot
Comment 5 2012-10-29 12:00:59 PDT
Comment on attachment 171255 [details] Patch Clearing flags on attachment: 171255 Committed r132834: <http://trac.webkit.org/changeset/132834>
WebKit Review Bot
Comment 6 2012-10-29 12:01:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.