Bug 100644

Summary: Don't expose implementation details of StylePropertySet storage.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, dglazkov, d-r, fmalita, koivisto, macpherson, menard, mifenton, pdr, peter+ews, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
A patch?
koivisto: review+, eflews.bot: commit-queue-
Patch for landing none

Description Andreas Kling 2012-10-29 02:37:28 PDT 
Don't expose implementation details of StylePropertySet storage.
Comment 1 Andreas Kling 2012-10-29 02:38:47 PDT 
Created attachment 171185 [details]
A patch?
Comment 2 Antti Koivisto 2012-10-29 02:50:47 PDT 
Comment on attachment 171185 [details]
A patch?

View in context: https://bugs.webkit.org/attachment.cgi?id=171185&action=review

Nice!

> Source/WebCore/css/StylePropertySet.h:57
> +    class PropertyReference {

StylePropertySet::PropertyReference sounds bit redundant but I don't have better suggestions.
Comment 3 EFL EWS Bot 2012-10-29 02:51:48 PDT 
Comment on attachment 171185 [details]
A patch?

Attachment 171185 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14618680
Comment 4 WebKit Review Bot 2012-10-29 03:02:12 PDT 
Comment on attachment 171185 [details]
A patch?

Attachment 171185 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14629072
Comment 5 Peter Beverloo (cr-android ews) 2012-10-29 03:12:29 PDT 
Comment on attachment 171185 [details]
A patch?

Attachment 171185 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14576041
Comment 6 Andreas Kling 2012-10-29 04:07:42 PDT 
Created attachment 171197 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-10-29 04:44:49 PDT 
Comment on attachment 171197 [details]
Patch for landing

Clearing flags on attachment: 171197

Committed r132786: <http://trac.webkit.org/changeset/132786>
Comment 8 WebKit Review Bot 2012-10-29 04:44:54 PDT 
All reviewed patches have been landed.  Closing bug.