Summary: | REGRESSION(r132757): It made 2 jquery tests assert | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Critical | CC: | fpizlo, oliver, ossy | ||||||||
Priority: | P1 | Keywords: | InRadar, Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 79668, 100620 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2012-10-29 00:42:03 PDT
This bug is valid on Qt too, I skipped the asserting tests to paint the bots green - r132923. Please unskip them with the proper fix. And it is P1/critical, because it is an assertion and regression. ping? I think we should revert the original change if the author is unavailable to fix the regression. (In reply to comment #4) > I think we should revert the original change if the author is unavailable to fix the regression. I do not see this crash on Mac. (In reply to comment #5) > (In reply to comment #4) > > I think we should revert the original change if the author is unavailable to fix the regression. > > I do not see this crash on Mac. It doesn't mean if the crash is invalid. The crash/assertion occured on EFL debug and on Qt debug buildbots. If you have any idea, I willingly check it on Qt to help debugging this bug, but I can't debug it myself, because I don't know anything about your original patch. (In reply to comment #7) > If you have any idea, I willingly check it on Qt to help debugging this bug, > but I can't debug it myself, because I don't know anything about your original patch. Does it reproduce to the point where you can catch the assertion in gdb? If so, can you show me what the contents of 'm_state.forNode(node.child1())' is? Also, if you could enable DFG_ENABLE_DEBUG_VERBOSE (in DFGCommon.h) and show me the output dump from that, that would be absolutely fabulous. Hm, it seems the assertions disappeared after http://trac.webkit.org/changeset/133160. Is it possible if it was the proper fix for this bug? Or did it make the bug hidden? For the record, I also tried to reproduce the crashing on EFL port today and could not. (In reply to comment #9) > Hm, it seems the assertions disappeared after http://trac.webkit.org/changeset/133160. Is it possible if it was the proper fix for this bug? Or did it make the bug hidden? No, it is impossible. All tests crashed between r133138-r133160, r133135 is the revision fixed this bug. Created attachment 172346 [details] verbose DRT output 1 on r133134 Created attachment 172348 [details] verbose DRT output 2 on r133134 Created attachment 172349 [details]
GDB backtrace for jquery/manipulation.html
Could you check if http://trac.webkit.org/changeset/133135 fixed this bug properly or only made this bug hidden? I unskipped them by r133487, but it would be great if you can confirm if r133135 is the proper fix for this bug or not. (In reply to comment #15) > Could you check if http://trac.webkit.org/changeset/133135 fixed this bug properly or only made this bug hidden? It's a real fix. Thanks. |