Bug 100628 – Remove an un-necessary connection to X-Server

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Kalyan]

In GraphicsSurfacePrivate constructor we make a connection to Xserver
        for gaining access to the screens in the display.Immediately(in constructor itself)
        we ask the display from offscreenwindow.
        Removing the former connection as we use the Display returned by offscreenwindow.

[Kalyan]

Created attachment 171159 [details]
proposed-patch

Patch

[Kalyan]

After the following changeset we always use the Display returned by offscreenwindow:

 https://bugs.webkit.org/show_bug.cgi?id=100523

[Kenneth Rohde Christiansen]

Comment on attachment 171159 [details]
proposed-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171159&action=review

> Source/WebCore/ChangeLog:8
> +        for gaining access to the screens in the display.Immediately(in constructor itself)
> +        we ask the display from offscreenwindow.

Space before Immediately and before the (. Maybe it should be on a new line

Try to make the changelogs easy readable

> Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:133
>          , m_hasAlpha(false)
>      {
>          GLXContext shareContextObject = 0;
> -        m_display = XOpenDisplay(0);
> +        m_display = m_offScreenWindow.display();

sorry is m_offScreenWindow initialized here? it is not in the initializer list

[Kalyan]

(In reply to comment #3)
> (From update of attachment 171159 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171159&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        for gaining access to the screens in the display.Immediately(in constructor itself)
> > +        we ask the display from offscreenwindow.
> 
> Space before Immediately and before the (. Maybe it should be on a new line
> 
> Try to make the changelogs easy readable
> 
> > Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:133
> >          , m_hasAlpha(false)
> >      {
> >          GLXContext shareContextObject = 0;
> > -        m_display = XOpenDisplay(0);
> > +        m_display = m_offScreenWindow.display();
> 
> sorry is m_offScreenWindow initialized here? it is not in the initializer list
m_offScreenWindow is a member variable of GraphicsSurfacePrivate. 
It is created here and increments refcount (static member variable) in its constructor.
It would create a window and open connection to display on calls to 
getXWindow () and display () respectively.

[Kalyan]

Created attachment 171513 [details]
patch2

Review changes

[WebKit Review Bot]

Comment on attachment 171513 [details]
patch2

Clearing flags on attachment: 171513

Committed r133147: <http://trac.webkit.org/changeset/133147>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.