Bug 100593

Summary: Web Inspector: Restoring breakpoints for formatted UISourceCode should be triggered by BreakpointManager, not ScriptsPanel.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, dglazkov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Vsevolod Vlasov
Reported 2012-10-27 08:09:50 PDT
Patch to follow.
Attachments
Patch (14.50 KB, patch)
2012-10-27 08:17 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-10-27 08:17:18 PDT
Created attachment 171091 [details] Patch
WebKit Review Bot
Comment 2 2012-10-27 18:09:52 PDT
Comment on attachment 171091 [details] Patch Attachment 171091 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14615607 New failing tests: inspector/debugger/linkifier.html inspector/debugger/script-formatter-console.html inspector/debugger/script-formatter-breakpoints.html inspector/debugger/script-formatter-search.html
Build Bot
Comment 3 2012-10-28 03:01:42 PDT
Comment on attachment 171091 [details] Patch Attachment 171091 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14617700 New failing tests: inspector/debugger/script-formatter-console.html inspector/debugger/script-formatter-breakpoints.html inspector/debugger/script-formatter-search.html
Pavel Feldman
Comment 4 2012-10-29 01:25:31 PDT
Comment on attachment 171091 [details] Patch I thought that formatting was encapsulated in the UI layer, why does breakpoint manager need to care about it?
WebKit Review Bot
Comment 5 2012-11-01 05:27:55 PDT
Comment on attachment 171091 [details] Patch Clearing flags on attachment: 171091 Committed r133151: <http://trac.webkit.org/changeset/133151>
WebKit Review Bot
Comment 6 2012-11-01 05:27:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.