Bug 100571

Summary: [EFL] Refactor tooltip callback signal in WebKit1
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2012-10-26 16:16:43 PDT
Separate tooltip callback signal to 'tooltip,text,set' and 'tooltip,text,unset' to synchronize with WebKit2.
Attachments
Patch (5.18 KB, patch)
2012-10-26 16:55 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2012-10-30 01:03 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-10-26 16:55:40 PDT
Created attachment 171050 [details] Patch
Ryuan Choi
Comment 2 2012-10-29 23:25:55 PDT
(In reply to comment #1) > Created an attachment (id=171050) [details] > Patch LGTM. Thanks.
Gyuyoung Kim
Comment 3 2012-10-30 00:13:32 PDT
Comment on attachment 171050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171050&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:-3494 > - * Set tooltip text and display if it is currently hidden. Should we remove this comment ? > Source/WebKit/efl/ewk/ewk_view.cpp:3495 > + */ Looks wrong indentation.
Jinwoo Song
Comment 4 2012-10-30 00:28:48 PDT
Comment on attachment 171050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171050&action=review >> Source/WebKit/efl/ewk/ewk_view.cpp:-3494 >> - * Set tooltip text and display if it is currently hidden. > > Should we remove this comment ? It's recommendation by Kenneth that we do not need to document the internal functions because they are tend to change. https://bugs.webkit.org/show_bug.cgi?id=98589 >> Source/WebKit/efl/ewk/ewk_view.cpp:3495 >> + */ > > Looks wrong indentation. I'll fix it.
Jinwoo Song
Comment 5 2012-10-30 01:03:58 PDT
Created attachment 171389 [details] Patch
WebKit Review Bot
Comment 6 2012-10-30 02:00:25 PDT
Comment on attachment 171389 [details] Patch Clearing flags on attachment: 171389 Committed r132881: <http://trac.webkit.org/changeset/132881>
WebKit Review Bot
Comment 7 2012-10-30 02:00:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.