| Summary: | Coordinated Graphics: Animation jerkiness when rAF is enabled | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Noam Rosenthal <noam> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | dglazkov, jturcotte, ossy, webkit.review.bot | ||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Noam Rosenthal
2012-10-26 10:14:45 PDT
Created attachment 170951 [details]
Patch
Comment on attachment 170951 [details]
Patch
I have another fix that's better :)
Created attachment 171024 [details]
Patch
Comment on attachment 171024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171024&action=review > Source/WebKit2/ChangeLog:17 > + UI process has actually painted the previous frame. We do so by sending a > + RequestAnimationFrame message to the UI process, which resonds with AnimationFrameReady > + after the UI process paints. > + > + * UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp: Tests??? > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:184 > +} > +void LayerTreeCoordinatorProxy::animationFrameReady() missing newline Created attachment 171030 [details]
Patch
Comment on attachment 171030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171030&action=review > Source/WebKit2/ChangeLog:10 > + frame returns right away instead of wait till the previous frame is actually rendered. waiting? > Source/WebKit2/ChangeLog:14 > + RequestAnimationFrame message to the UI process, which resonds with AnimationFrameReady responds? > Source/WebKit2/ChangeLog:18 > + This code path is tested by existing requestAnimationFrame tests. There is no > + infrastructure to test animation jerkiness beyond that. why wasnt it caught before? Created attachment 171038 [details]
Patch
Created attachment 171045 [details]
Patch
Created attachment 171047 [details]
Patch
Comment on attachment 171047 [details] Patch Attachment 171047 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14614295 New failing tests: fast/animation/request-animation-frame-too-rapid.html Created attachment 171095 [details]
Patch
Comment on attachment 171095 [details] Patch Attachment 171095 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14614521 New failing tests: fast/animation/request-animation-frame-too-rapid.html Created attachment 171102 [details]
Patch for landing
Patch should work fine with Chromium/Mac tests now - if it gives trouble to anyone please feel free to roll out. Created attachment 171104 [details]
Patch for landing
Created attachment 171105 [details]
Patch for landing
Comment on attachment 171105 [details] Patch for landing Clearing flags on attachment: 171105 Committed r132742: <http://trac.webkit.org/changeset/132742> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 171112 [details]
Patch for landing
Comment on attachment 171112 [details] Patch for landing Clearing flags on attachment: 171112 Committed r132747: <http://trac.webkit.org/changeset/132747> All reviewed patches have been landed. Closing bug. It seems CQ is unreliable and extremely slow. :( Using it for important buildfixes isn't a good idea. Could you commit buildfixes directly next time please? |