Bug 100520

Summary:

Web Inspector: Fix log-type icon alignment.

Product:

WebKit

Reporter:

Mike West <mkwst>

Component:

Web Inspector (Deprecated)

Assignee:

Mike West <mkwst>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

apavlov, dubroy, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Before the patch.	none
After.	none
Patch	none
Patch for landing	none

Mike West

Reported 2012-10-26 07:30:03 PDT

Created attachment 170922 [details] Before the patch. The warning/error/whatever icons are just a pixel or two off, and it's driving me nuts. :)

Attachments
Before the patch. (121.49 KB, image/png) 2012-10-26 07:30 PDT, Mike West	no flags	Details
After. (122.78 KB, image/png) 2012-10-26 07:30 PDT, Mike West	no flags	Details
Patch (1.75 KB, patch) 2012-10-26 07:31 PDT, Mike West	no flags	Details Formatted Diff Diff
Patch for landing (1.72 KB, patch) 2012-10-26 08:08 PDT, Mike West	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mike West

Comment 1 2012-10-26 07:30:20 PDT

Created attachment 170923 [details] After.

Mike West

Comment 2 2012-10-26 07:31:14 PDT

Created attachment 170924 [details] Patch

WebKit Review Bot

Comment 3 2012-10-26 07:52:35 PDT

Comment on attachment 170924 [details] Patch Rejecting attachment 170924 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12787. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14593700

Mike West

Comment 4 2012-10-26 08:08:33 PDT

Created attachment 170929 [details] Patch for landing

WebKit Review Bot

Comment 5 2012-10-26 09:12:51 PDT

Comment on attachment 170929 [details] Patch for landing Clearing flags on attachment: 170929 Committed r132668: <http://trac.webkit.org/changeset/132668>

WebKit Review Bot

Comment 6 2012-10-26 09:12:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.