Bug 100516 – Web Inspector: Make compact mode the only toolbar mode.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED INVALID

Web Inspector: Make compact mode the only toolbar mode.

Created attachment 170915 [details]
Patch

Created attachment 171190 [details]
Patch

New patch to fix a few problems:
- When overflowing in dock-to-right, the top part of the overflowed items was visible.
- Also fixed an old regression where the overflow menu was obscured.

[Pavel Feldman]

Comment on attachment 171190 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171190&action=review

Overall looks good. Why do we need the dock-to-bottom style?

> Source/WebCore/inspector/front-end/helpScreen.css:10
> +body.dock-to-bottom .help-window-outer {

This will now be the same for all modes, just inline the .compact overrides into the main rules.

> Source/WebCore/inspector/front-end/helpScreen.css:27
> +body.dock-to-bottom .help-window-main {

ditto

> Source/WebCore/inspector/front-end/helpScreen.css:94
> +body.dock-to-bottom .help-content {

ditto

> Source/WebCore/inspector/front-end/helpScreen.css:250
> +body:not(.dock-to-bottom) #settings-screen .tabbed-pane {

ditto

> Source/WebCore/inspector/front-end/inspector.css:108
>  .toolbar-icon {

Here you do as I suggest, why didn't you do it for the help screen above?

Comment on attachment 171190 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171190&action=review

>> Source/WebCore/inspector/front-end/helpScreen.css:10
>> +body.dock-to-bottom .help-window-outer {
> 
> This will now be the same for all modes, just inline the .compact overrides into the main rules.

When docked to bottom, the help screen covers the entire area below the toolbar. In other modes, it doesn't -- it has rounded corners and is inset a bit.

I assumed that we want to keep this behaviour.

[Pavel Feldman]

> When docked to bottom, the help screen covers the entire area below the toolbar. In other modes, it doesn't -- it has rounded corners and is inset a bit.
> 
> I assumed that we want to keep this behaviour.

Got it, makes sense. The only thing preventing me from r+ - ing this change is the slight horizontal space regression in the dock-to-right mode: in my default setup Console is no longer visible by default.

I tried making the icons smaller, but there still is significant regression (see the screenshot attached).

[Pavel Feldman]

Created attachment 171207 [details]
[IMAGE] with smaller icons