Bug 100505

Summary: [EFL][WK2] Simplify getting impl from ewk_view evas object instance
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100226    
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2012-10-26 05:03:14 PDT
Currently have to use 2 macros to get impl from ewk_view evas object instance, should be simplified to one.
Attachments
patch (27.21 KB, patch)
2012-10-29 07:25 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-10-29 07:25:05 PDT
Created attachment 171245 [details] patch
Chris Dumez
Comment 2 2012-10-29 07:30:37 PDT
Comment on attachment 171245 [details] patch How come we're not using EwkViewImpl::fromEvasObject() at all?
Kenneth Rohde Christiansen
Comment 3 2012-10-29 07:36:52 PDT
(In reply to comment #2) > (From update of attachment 171245 [details]) > How come we're not using EwkViewImpl::fromEvasObject() at all? Good question.
Mikhail Pozdnyakov
Comment 4 2012-10-29 09:02:59 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 171245 [details] [details]) > > How come we're not using EwkViewImpl::fromEvasObject() at all? > > Good question. Well, EwkViewImpl::fromEvasObject() is for internal usage, it does not have all that null checking and failure logging but has assertions instead. So I would say given macro here is more appropriate.
WebKit Review Bot
Comment 5 2012-10-30 01:43:20 PDT
Comment on attachment 171245 [details] patch Clearing flags on attachment: 171245 Committed r132879: <http://trac.webkit.org/changeset/132879>
WebKit Review Bot
Comment 6 2012-10-30 01:43:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.