Bug 10049

Summary:

REGRESSION: thick focus ring is drawn around popup menus

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

aestes, andersca, dev+webkit, emacemac7, jonathanjohnsson, jonlee, joost, mbritto, mitz, myyodo, simon.fraser

Priority:

Keywords:

HasReduction, InRadar, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.superbus.co.il

Attachments:

Description	Flags
Test case reduction	none
Test case	none
Clip to the enclosing rectangle if you decide to paint all of it	none

Alexey Proskuryakov

Reported 2006-07-21 11:54:32 PDT

Steps to reproduce: 1) Open <http://www.superbus.co.il>. 2) Open and close one of the popup menus in the top menu. Results: the focus ring apparently gets drawn multiple times, so it becomes solid color.

Attachments
Test case reduction (575 bytes, text/html) 2006-08-02 17:36 PDT, jonathanjohnsson	no flags	Details
Test case (596 bytes, text/html) 2007-08-09 10:52 PDT, mitz	no flags	Details
Clip to the enclosing rectangle if you decide to paint all of it (1.51 KB, patch) 2007-08-11 01:12 PDT, mitz	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2006-07-21 19:47:31 PDT

Wow, that's a really neat effect!

jonathanjohnsson

Comment 2 2006-08-02 17:36:56 PDT

Created attachment 9842 [details] Test case reduction

jonathanjohnsson

Comment 3 2006-08-02 17:40:20 PDT

Changing to "HasReduction", even if it might be possible to make the current one shorter. I fiddled with it quite a bit without being able to reduce it more.

Stephanie Lewis

Comment 4 2006-11-06 18:48:40 PST

radar 4769769

Joost de Valk (AlthA)

Comment 5 2007-01-19 04:50:08 PST

Why is this P1? Moving to P2...

Joost de Valk (AlthA)

Comment 6 2007-01-19 04:51:19 PST

And I did notice that it's a regression, yet, somehow this doesn't seem that much of a priority to me :)

mitz

Comment 7 2007-05-16 23:37:00 PDT

(In reply to comment #6) > And I did notice that it's a regression, yet, somehow this doesn't seem that > much of a priority to me :) > A variant of this bug, with a search field instead of a popup, affects <http://www.apple.com/buy/locator/>.

Dave Hyatt

Comment 8 2007-05-16 23:42:20 PDT

Regression = p1.

mitz

Comment 9 2007-08-09 10:52:42 PDT

Created attachment 15883 [details] Test case This test case demonstrates that the overpainting happens when WebHTMLView takes the "use unioned rect" code path, the focus ring lies in the "unioned rect" but not in any of the actual damaged rects. I think the reason is that in that case, the -[WebClipView _focusRingVisibleRect] includes the non-damaged area (which is clipped out for normal drawing).

mitz

Comment 10 2007-08-11 01:12:58 PDT

Created attachment 15926 [details] Clip to the enclosing rectangle if you decide to paint all of it The idea here is that if WebHTMLView decides to paint the "unioned rect" instead of individual rects, it should clip to that. This patch may be a no-go due to performance considerations -- obviously the paint() methods will do the same amount of work, but maybe Core Graphics will have to work a lot harder. Another problem with this patch is that it makes the fast/repaint tests ineffective (another way to look at it is that it will often allow incremental repaint bugs to go unnoticed). And now while typing this comment I got the impression that this patch made "focus rings around text controls" bugs much more noticeable.

mitz

Comment 11 2007-09-01 01:33:59 PDT

I'm also seeing doubly-painted focus rings in Gmail under certain Safari/OS combinations.

Alexey Proskuryakov

Comment 12 2008-07-28 02:20:27 PDT

Only the last reduction ("Test case") fails for me now.

Alexey Proskuryakov

Comment 13 2010-06-15 10:03:04 PDT